From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE71DA0487 for ; Thu, 4 Jul 2019 08:20:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B1E14CE4; Thu, 4 Jul 2019 08:20:45 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 76D104CA6; Thu, 4 Jul 2019 08:20:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 23:20:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="154967191" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 03 Jul 2019 23:20:42 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 23:20:41 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 23:20:41 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 14:20:38 +0800 From: "Pei, Andy" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Zhang, Helin" , "stable@dpdk.org" , "Zhang, Roy Fan" , "Wu, Jingjing" , "Xing, Beilei" , "Yigit, Ferruh" , "Xu, Rosen" , "Ye, Xiaolong" Thread-Topic: [PATCH v4] net/i40e: fix core dumped when setting txq or rxq to 0 in VF Thread-Index: AQHVMgoqESzKZzvgqkiXKbEeRRwmmKa5/A7ggAABAPA= Date: Thu, 4 Jul 2019 06:20:38 +0000 Message-ID: <5941F446C088714A85408FA3132CFCBB01044326@SHSMSX105.ccr.corp.intel.com> References: <1561108988-217617-1-git-send-email-andy.pei@intel.com> <1562204319-15833-1-git-send-email-andy.pei@intel.com> <039ED4275CED7440929022BC67E7061153D5FC3B@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D5FC3B@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix core dumped when setting txq or rxq to 0 in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Qi -----Original Message----- From: Zhang, Qi Z=20 Sent: Thursday, July 4, 2019 2:18 PM To: Pei, Andy ; dev@dpdk.org Cc: Zhang, Helin ; stable@dpdk.org; Zhang, Roy Fan <= roy.fan.zhang@intel.com>; Wu, Jingjing ; Xing, Beile= i ; Yigit, Ferruh ; Xu, Rose= n ; Ye, Xiaolong Subject: RE: [PATCH v4] net/i40e: fix core dumped when setting txq or rxq t= o 0 in VF > -----Original Message----- > From: Pei, Andy > Sent: Thursday, July 4, 2019 9:39 AM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Helin=20 > ; stable@dpdk.org; Zhang, Roy Fan=20 > ; Zhang, Qi Z ; Wu,=20 > Jingjing ; Xing, Beilei=20 > ; Yigit, Ferruh ; Xu,=20 > Rosen ; Ye, Xiaolong > Subject: [PATCH v4] net/i40e: fix core dumped when setting txq or rxq=20 > to 0 in VF >=20 > Testpmd would stuck and result in core dump when user specifies an=20 > invalid VF queue number, for example when setting txq or rxq to 0. > When txq or rxq is set to 0, pointer of pointer rxq or txq in function=20 > i40evf_configure_vsi_queues is NULL. The usage of txq[i] or rxq[0] is=20 > valid. This patch fixes this issue. >=20 > Fixes: d6b19729093e ("i40evf: support configurable crc stripping") > Cc: helin.zhang@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi