From: "Pei, Andy" <andy.pei@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: i40e get link status update from ipn3ke
Date: Thu, 4 Jul 2019 07:03:31 +0000 [thread overview]
Message-ID: <5941F446C088714A85408FA3132CFCBB0104436D@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061153D5C701@SHSMSX105.ccr.corp.intel.com>
Hi Qi,
I will do it in v3.
Thanks
-----Original Message-----
From: Zhang, Qi Z
Sent: Sunday, June 30, 2019 8:36 AM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xu, Rosen <rosen.xu@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>; stable@dpdk.org
Subject: RE: [PATCH v2] net/i40e: i40e get link status update from ipn3ke
> -----Original Message-----
> From: Pei, Andy
> Sent: Friday, June 28, 2019 4:33 PM
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Xu, Rosen <rosen.xu@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/i40e: i40e get link status update from ipn3ke
>
> Add switch_mode argument for i40e PF to specify the specific FPGA that
> i40e PF is connected to. i40e PF get link status update via the connected FPGA.
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
....
> @@ -2799,6 +2913,10 @@ void i40e_flex_payload_reg_set_default(struct
> i40e_hw *hw)
> else
> update_link_aq(hw, &link, enable_lse, wait_to_complete);
>
> + devargs = pci_dev->device.devargs;
> + if (devargs)
> + i40e_pf_linkstatus_get_from_switch_ethdev(devargs, &link);
It's not necessary to check devargs every time we do i40e_dev_link_update, its better initialize the ipn3ke mode during initialization (add some field in i40e_adapter maybe), so we can reuse the result at runtime
> +
......
next prev parent reply other threads:[~2019-07-04 7:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:14 [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke Andy Pei
2019-05-24 1:05 ` Xu, Rosen
2019-05-24 13:12 ` Ferruh Yigit
2019-05-27 1:42 ` Pei, Andy
2019-06-10 6:14 ` Pei, Andy
2019-06-11 2:35 ` Xu, Rosen
2019-06-25 9:06 ` Pei, Andy
2019-06-26 15:33 ` Ye Xiaolong
2019-06-27 1:20 ` Pei, Andy
2019-06-28 8:33 ` [dpdk-dev] [PATCH v2] net/i40e: i40e get link status update from ipn3ke Andy Pei
2019-06-30 0:35 ` Zhang, Qi Z
2019-07-04 7:03 ` Pei, Andy [this message]
2019-07-04 6:56 ` [dpdk-dev] [PATCH v3] " Andy Pei
2019-07-08 3:03 ` [dpdk-dev] [PATCH v4] " Andy Pei
2019-07-08 7:27 ` Zhang, Qi Z
2019-07-09 6:43 ` [dpdk-dev] [PATCH v5] " Andy Pei
2019-07-10 9:41 ` [dpdk-dev] [PATCH v6 1/2] " Andy Pei
2019-07-11 4:36 ` Zhang, Qi Z
2019-07-11 5:56 ` Pei, Andy
2019-07-11 6:05 ` Pei, Andy
2019-07-11 6:39 ` [dpdk-dev] [PATCH v7] " Andy Pei
2019-07-11 8:45 ` Zhang, Qi Z
2019-07-10 9:41 ` [dpdk-dev] [PATCH v6 2/2] doc: add switch mode devargs Andy Pei
2019-07-08 5:56 ` [dpdk-dev] [PATCH v3] net/i40e: i40e get link status update from ipn3ke Zhang, Qi Z
2019-07-08 8:59 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5941F446C088714A85408FA3132CFCBB0104436D@SHSMSX105.ccr.corp.intel.com \
--to=andy.pei@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).