From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E7B1A0487 for ; Thu, 4 Jul 2019 09:03:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37913CFA6; Thu, 4 Jul 2019 09:03:37 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8D8684D27; Thu, 4 Jul 2019 09:03:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 00:03:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="154976218" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 04 Jul 2019 00:03:34 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 00:03:33 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 00:03:33 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 15:03:31 +0800 From: "Pei, Andy" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Yigit, Ferruh" , "Xu, Rosen" , "Ye, Xiaolong" , "Zhang, Roy Fan" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: i40e get link status update from ipn3ke Thread-Index: AQHVLY0qW5W6WLObVkSnsfpN+hPlLKazV5PQgAa6WZA= Date: Thu, 4 Jul 2019 07:03:31 +0000 Message-ID: <5941F446C088714A85408FA3132CFCBB0104436D@SHSMSX105.ccr.corp.intel.com> References: <1558602875-429451-1-git-send-email-andy.pei@intel.com> <1561710791-356325-1-git-send-email-andy.pei@intel.com> <039ED4275CED7440929022BC67E7061153D5C701@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D5C701@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: i40e get link status update from ipn3ke X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, I will do it in v3. Thanks -----Original Message----- From: Zhang, Qi Z=20 Sent: Sunday, June 30, 2019 8:36 AM To: Pei, Andy ; dev@dpdk.org Cc: Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh ; Xu, Rosen = ; Ye, Xiaolong ; Zhang, Roy Fan ; stable@dpdk.org Subject: RE: [PATCH v2] net/i40e: i40e get link status update from ipn3ke > -----Original Message----- > From: Pei, Andy > Sent: Friday, June 28, 2019 4:33 PM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Qi Z=20 > ; Wu, Jingjing ; Xing,=20 > Beilei ; Yigit, Ferruh=20 > ; Xu, Rosen ; Ye, Xiaolong=20 > ; Zhang, Roy Fan ;=20 > stable@dpdk.org > Subject: [PATCH v2] net/i40e: i40e get link status update from ipn3ke >=20 > Add switch_mode argument for i40e PF to specify the specific FPGA that=20 > i40e PF is connected to. i40e PF get link status update via the connected= FPGA. >=20 > Signed-off-by: Andy Pei > --- .... > @@ -2799,6 +2913,10 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > else > update_link_aq(hw, &link, enable_lse, wait_to_complete); >=20 > + devargs =3D pci_dev->device.devargs; > + if (devargs) > + i40e_pf_linkstatus_get_from_switch_ethdev(devargs, &link); It's not necessary to check devargs every time we do i40e_dev_link_update, = its better initialize the ipn3ke mode during initialization (add some field= in i40e_adapter maybe), so we can reuse the result at runtime > + ......