From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F0B3A2EFC for ; Tue, 17 Sep 2019 09:30:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 907001BFB2; Tue, 17 Sep 2019 09:29:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 683B81BF71 for ; Tue, 17 Sep 2019 09:29:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 00:29:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,515,1559545200"; d="scan'208";a="386463175" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 17 Sep 2019 00:29:55 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 00:29:54 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 00:29:54 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.53]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 15:29:52 +0800 From: "Pei, Andy" To: "Wang, Xiao W" , "dev@dpdk.org" CC: "Xu, Rosen" , "Ye, Xiaolong" , "Bie, Tiwei" , "Liang, Cunming" Thread-Topic: [PATCH 3/4] vhost: call vDPA callback at the end of vring enable handler Thread-Index: AQHVZGPfe7jGPMN760u12iP8/wQw8KcnpAsAgAfmbnA= Date: Tue, 17 Sep 2019 07:29:52 +0000 Message-ID: <5941F446C088714A85408FA3132CFCBB01072E0F@SHSMSX105.ccr.corp.intel.com> References: <1567740051-367172-1-git-send-email-andy.pei@intel.com> <1567740051-367172-3-git-send-email-andy.pei@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/4] vhost: call vDPA callback at the end of vring enable handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, I will do this way in v2. -----Original Message----- From: Wang, Xiao W=20 Sent: Thursday, September 12, 2019 3:42 PM To: Pei, Andy ; dev@dpdk.org Cc: Xu, Rosen ; Ye, Xiaolong ; B= ie, Tiwei ; Liang, Cunming Subject: RE: [PATCH 3/4] vhost: call vDPA callback at the end of vring enab= le handler Hi Andy, > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 6, 2019 11:21 AM > To: dev@dpdk.org > Cc: Xu, Rosen ; Ye, Xiaolong=20 > ; Bie, Tiwei ; Wang, Xiao=20 > W > Subject: [PATCH 3/4] vhost: call vDPA callback at the end of vring=20 > enable handler >=20 > vDPA's set_vring_state callback would need to know the virtqueues' > enable status to configure the hardware. >=20 > Signed-off-by: Xiaolong Ye > Signed-off-by: Andy Pei > --- > lib/librte_vhost/rte_vdpa.h | 4 ++-- > lib/librte_vhost/vhost_user.c | 5 +++-- > 2 files changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h=20 > index 9a3deb3..19cf897 100644 > --- a/lib/librte_vhost/rte_vdpa.h > +++ b/lib/librte_vhost/rte_vdpa.h > @@ -54,8 +54,8 @@ struct rte_vdpa_dev_ops { > int (*dev_conf)(int vid); > int (*dev_close)(int vid); >=20 > - /** Enable/disable this vring */ > - int (*set_vring_state)(int vid, int vring, int state); > + /** Enable/disable vring queue pairs */ > + int (*set_vring_state)(int vid); If rte_vhost_get_active_vring_num() always needs be called inside set_vring= _state callback, inorder to get the active queue pair number, then why not = pass the active queue pair number directly as a parameter to set_vring_stat= e() ? This could help to avoid exposing new API. BRs, Xiao >=20 > /** Set features when changed */ > int (*set_features)(int vid); > diff --git a/lib/librte_vhost/vhost_user.c=20 > b/lib/librte_vhost/vhost_user.c index 0b72648..21028cc 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1346,8 +1346,6 @@ static int vhost_user_set_vring_err(struct=20 > virtio_net **pdev __rte_unused, >=20 > did =3D dev->vdpa_dev_id; > vdpa_dev =3D rte_vdpa_get_device(did); > - if (vdpa_dev && vdpa_dev->ops->set_vring_state) > - vdpa_dev->ops->set_vring_state(dev->vid, index, enable); >=20 > if (dev->notify_ops->vring_state_changed) > dev->notify_ops->vring_state_changed(dev->vid, > @@ -1359,6 +1357,9 @@ static int vhost_user_set_vring_err(struct=20 > virtio_net **pdev __rte_unused, >=20 > dev->virtqueue[index]->enabled =3D enable; >=20 > + if (vdpa_dev && vdpa_dev->ops->set_vring_state) > + vdpa_dev->ops->set_vring_state(dev->vid); > + > return RTE_VHOST_MSG_RESULT_OK; > } >=20 > -- > 1.8.3.1