From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
bruce.richardson@intel.com,
Shepard Siegel <shepard.siegel@atomicrules.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers
Date: Wed, 24 Mar 2021 12:30:36 +0100 [thread overview]
Message-ID: <5945384.p3lA8Brad8@thomas> (raw)
In-Reply-To: <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com>
24/03/2021 12:27, Ferruh Yigit:
> On 3/24/2021 4:32 AM, Tyler Retzlaff wrote:
> > On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
> >>> diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
> >>> index c37b2e377..4353fa6b7 100644
> >>> --- a/lib/librte_ethdev/meson.build
> >>> +++ b/lib/librte_ethdev/meson.build
> >>> @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
> >>> 'rte_mtr_driver.h',
> >>> 'rte_tm.h',
> >>> 'rte_tm_driver.h')
> >>> +
> >>> indirect_headers += files(
> >>> 'rte_ethdev_core.h',
> >>> 'rte_eth_ctrl.h')
> >>> +driver_sdk_headers += files(
> >>> + 'ethdev_driver.h',
> >>> + 'ethdev_pci.h',
> >>> + 'ethdev_vdev.h')
> >>> +
> >>> deps += ['net', 'kvargs', 'meter', 'telemetry']
> >>
> >
> > i feel like i missed a reply here. but just to clarify only ethdev will
> > be covered by this patch. inclusion of other driver headers was
> > discussed off list (sorry) and it emerged that it would result in
> > withdraw a number of driver api/abi that had not been marked as
> > __rte_internal.
> >
> > for driver api that were being exported as 'stable' a deprecation notice
> > will need to be issued in order to make them part of the
> > driver_sdk_headers. for that reason only ethdev is being made available
> > under this option for now.
> >
> > please ack/nack the patch as-is
> >
>
> I am OK the patch for the ethdev part, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>
> But not sure how to manage the same problem for whole project, if install all
> headers in one patch, or add them gradually via separate patches by time ...
We did a cleanup in ethdev but not in other driver classes.
When the cleanup will be done gradually, the headers
must move in this new category driver_sdk_headers.
next prev parent reply other threads:[~2021-03-24 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 19:27 [dpdk-dev] [PATCH] " Tyler Retzlaff
2021-03-12 15:19 ` Ferruh Yigit
2021-03-12 15:25 ` David Marchand
2021-03-12 15:34 ` Bruce Richardson
2021-03-12 15:52 ` Thomas Monjalon
2021-03-12 18:43 ` Tyler Retzlaff
2021-03-12 22:20 ` [dpdk-dev] [PATCH v2] " Tyler Retzlaff
2021-03-15 10:06 ` Bruce Richardson
2021-03-23 17:04 ` Ferruh Yigit
2021-03-24 4:32 ` Tyler Retzlaff
2021-03-24 11:27 ` Ferruh Yigit
2021-03-24 11:30 ` Thomas Monjalon [this message]
2021-03-24 16:24 ` Tyler Retzlaff
2021-03-26 12:02 ` Ferruh Yigit
2021-03-26 20:52 ` Tyler Retzlaff
2021-03-29 9:43 ` Ferruh Yigit
2021-03-29 12:10 ` Thomas Monjalon
2021-03-29 15:23 ` Ferruh Yigit
2021-03-29 19:31 ` Thomas Monjalon
2021-03-30 12:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5945384.p3lA8Brad8@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).