From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 072A458F4 for ; Fri, 20 Feb 2015 16:22:39 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id l15so3642170wiw.3 for ; Fri, 20 Feb 2015 07:22:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Vc8gEr7+gOYTz1rLv5azaOWQ7n33sArHh+CnwW7XbB4=; b=PwVHHtsTh7MIqrT6iebYKSB39KlSM8QS0zgfummsCStdFyKLdU0dQ4giJSexuUpjgF 4P4Awob7R6OUumpARUys+4mYp5S6ARRxLdKITHcT8xqohJkDH4R4dnzRdfPwrIuiMyLN NEkT7WBEB6YLM7oaQD+3mSndCLVfDM2OW61xOmj03Mlf5PoDxDxE/fKRmKI9yY+VvDY2 QdvOlQumik+Gesb44wQald2D6TA2tV80RL8O7kItnAk0npVTUDTyD/RqGZ095XQBBypq GB187T++37HWsqBNNdjOFh/zR0LJmpeFvrg1/xCuoB+td/RF4xi876I9ukwpAKlEoQo8 6q+A== X-Gm-Message-State: ALoCoQmJE2Acegl++NisI0tjze7znuU/SBCWT33VAHTFh8XTdCzYfk5ibuJkZYr7HaM6uXxz2bzd X-Received: by 10.180.73.171 with SMTP id m11mr11076286wiv.21.1424445758919; Fri, 20 Feb 2015 07:22:38 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l6sm42500323wjx.33.2015.02.20.07.22.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 07:22:38 -0800 (PST) From: Thomas Monjalon To: "Gajdzica, MaciejX T" Date: Fri, 20 Feb 2015 16:22:07 +0100 Message-ID: <5954628.1jXzueXvyv@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <9CC680510C0AC140A846FED2EF7F962812E5F82E@IRSMSX102.ger.corp.intel.com> References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com> <1694402.UUemy3W7BY@xps13> <9CC680510C0AC140A846FED2EF7F962812E5F82E@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 15:22:39 -0000 2015-02-20 14:54, Gajdzica, MaciejX T: > > 2015-02-19 18:26, Michal Jastrzebski: > > > From: Maciej Gajdzica > > > > > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > > > address type from uint8_t[4] to uint32_t. Also removed union from > > > arp_hdr struct. Updated test-pmd to match new arp_hdr version. > > > > > > Signed-off-by: Maciej Gajdzica > > > > Why? > > "Changed A to B" is not a sufficient explanation. > > Hi Thomas > > I changed commit message to this: > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > address type from uint8_t[4] to uint32_t to make it consistent with other > DPDK code using MAC and IP addresses. It allows us to use is_same_ether_addr > and ether_addr_copy functions on MAC addresses in ARP header. Also > removed union from arp_hdr struct to make calls to arp_data items > shorter. Updated test-pmd to match new arp_hdr version. > > Is that sufficient? Yes it's far better! Thanks One day we could have a script to run before sending a patch. It would make some smoky tests and ask: "did you explain why you make this change?" ;) > This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. Please try to remove this footer. This email was distributed by the mailing list engine, despite it's prohibited. I don't want to go in jailhouse ;)