From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEF06A00C2; Wed, 17 Mar 2021 16:40:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C6E54069F; Wed, 17 Mar 2021 16:40:00 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 19C734067E; Wed, 17 Mar 2021 16:39:59 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8E31E5C01C9; Wed, 17 Mar 2021 11:39:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 17 Mar 2021 11:39:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= q6qglHUgXgIz5aadAQAtm6fD/KbX5WBVZh8aQaE9iXo=; b=FJJbo54LKtRF5OC8 kGPooVNSdF3CISf9aPMpxzk02zX+hcBMeqGRTYtAcvysmU5IrMfbn/v6B2Ptx+6y 8Fe6kZHW91I968AHsXgOQ69QcB2zSuIBpuCN/Wsk8fhBRGaU4QY2YujFb1pAhONU lWI4qAxwgsF2jR2huGzq7AUb5nAEJ+hj5SWYRlLk3p7NcTnhP6q47/73JFQutUiM qtvAfLOOqLwyQbQeLQDt0pGuv/RLUN0b3yrXO/37WlURRYjNyAd0/Wwo5EehpIdo 78s+iZTs392yETDpo8pAJ2aiKVjP+5+Pks7UOhYk0COApKBQJ+/R5wQestWnEZ0a Y5yPBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=q6qglHUgXgIz5aadAQAtm6fD/KbX5WBVZh8aQaE9i Xo=; b=fJEObmhSzBYG6CrZ25Rsro4DssdW60rcN4cVM6HtoVk8VCvtovYYpwOO4 rpf2+pPHlJHZPxCRmYgbTeIwtgnyqbuLXK8HhaaaHkAaYKKg/Xhcx7yeEx0JZxav 7CqPIW+hjDZayqLTdUK/cpcjffYBfpfEW0KRVuVfsq0iSWFXo+L1vwOVv16ZzgXo QJRF3x4/Tbyj2jt51BD4c5dDk1Ym7fto+Ev51FOoAvCMCaD0hNlmlNrJdSk3J6k7 ckBqHzMuvy0A9jz/BoyKjUUqzE6TUN06bIIakq+XdF8LZDRSn2lmiyd65Og1XeFN qArwCGk/Wr3jIlAMkwf3lX5Pw7K7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefgedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DE67108005C; Wed, 17 Mar 2021 11:39:57 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Bruce Richardson Cc: dev , dpdk stable Date: Wed, 17 Mar 2021 16:39:55 +0100 Message-ID: <59852780.U2hSXxEtjn@thomas> In-Reply-To: References: <20210317093124.965624-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix version macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/03/2021 16:36, David Marchand: > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > > > The macro RTE_VERSION is broken since updated with function calls. > > It is a build-time version number, and must be built with macros. > > For a run-time version number, there is the function rte_version(). > > > > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > > Cc: stable@dpdk.org > > > > Reported-by: David Marchand > > Signed-off-by: Thomas Monjalon > > Acked-by: David Marchand Applied quickly because the compilation of some apps are broken. > Let's discuss the versioning of the new symbols in the other thread. OK, in this thread: https://inbox.dpdk.org/dev/20210317151535.1412311-1-thomas@monjalon.net/