From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 866361B1A5
 for <dev@dpdk.org>; Fri,  6 Oct 2017 01:58:54 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 0096520C37;
 Thu,  5 Oct 2017 19:58:53 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 05 Oct 2017 19:58:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=0jC23o2JGicu0W2
 BX8jsgm3V5ynOPEoFg854zOAmETE=; b=LBpVS8NdPZdlBw1rdtwol8Flmo0wGda
 rrHJeHSKHllQY4uEfPXyeHiJqguCMwcR50ZnAbyF0xOTJunDBONjCm8/D7TFVNfp
 Mcc1ZntON217JdIHkAgmIAWlG9mpDSVsS5g2wuNzWtNi6CHHDBTFCAGqiqB1TI53
 NavJ/3a77LaM=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=0jC23o2JGicu0W2BX8jsgm3V5ynOPEoFg854zOAmETE=; b=pPHDt7uv
 cbVgQB/1ne/7arJ416tgd9Cxu5kxl6yHDu0iSe2c5DCFQYnYRpL8q3iwpKmZ25Uo
 KCvrUj2tFjUBP8o/2+AUPVtugVbTvY5R7c4SGJx5Xt8lQIFXQMIYiOFC2V7wMSP+
 FYEsAq2oyNcF+vx0mSTqhk3MTt+p8UpmUu5Mo0shDyo/QJxCem5RrTKbcOYUz1Cr
 4zBQ5qyCBSX7alKl8y2rLulPsdw3qNBjgnd5x3KFkCuYc4OlFKn1FF4ja7iUvGFp
 OhXPsg+ZlWbnJZVCR64iEkBxcEd3aMDXAYmxsaOV961gZhxoX9kH3IhGDmj0a1mC
 uVjTaLnAYcwOOQ==
X-ME-Sender: <xms:PcfWWYK8_mxSaTSZit59tpvvcPuhZs-EcVLS4cp0tmh5dDThwZ-CCQ>
X-Sasl-enc: DDCf1bbGtKWJAyzX+dZFI1wBcne36l0qUrbip7ClqoSs 1507247933
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 982082418B;
 Thu,  5 Oct 2017 19:58:53 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com, aconole@redhat.com, stephen@networkplumber.org,
 anatoly.burakov@intel.com, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com,
 bruce.richardson@intel.com, sergio.gonzalez.monroy@intel.com,
 maxime.coquelin@redhat.com
Date: Fri, 06 Oct 2017 01:58:52 +0200
Message-ID: <5989047.qJ3B3g597f@xps>
In-Reply-To: <20170920112356.17629-3-santosh.shukla@caviumnetworks.com>
References: <20170918104234.9149-1-santosh.shukla@caviumnetworks.com>
 <20170920112356.17629-1-santosh.shukla@caviumnetworks.com>
 <20170920112356.17629-3-santosh.shukla@caviumnetworks.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v9 2/9] eal/pci: get iommu class
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 23:58:54 -0000

This patch is introducing a new abstraction.
It is important to explain it for future readers of this code.

20/09/2017 13:23, Santosh Shukla:
> +/**
> + * IOVA mapping mode.
> + */

Please explain what IOVA means and what is the purpose of
distinguish the different modes.

> +enum rte_iova_mode {
> +	RTE_IOVA_DC = 0,	/* Don't care mode */
> +	RTE_IOVA_PA = (1 << 0),
> +	RTE_IOVA_VA = (1 << 1)
> +};

You should explain each value of the enum.