From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15A43A0547; Wed, 21 Apr 2021 20:27:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C65EA40687; Wed, 21 Apr 2021 20:27:11 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 5D44340150 for ; Wed, 21 Apr 2021 20:27:10 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4B7111E21; Wed, 21 Apr 2021 14:27:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 21 Apr 2021 14:27:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FKwIYbsOXqXtMTdr4wHrazWNfBdaldr0arvyiWK1wds=; b=bOfeqRjOFrmtfHCB dFtMdf0MeSU5bfq5RwPnKXsGgqenQAVlueE0/nEn0+CFT/xszMhCbghqmh+KfUqY qyL4RH4CKRb1IewOVs8AuwvSSpRsoHi3rFMmzUIpzB8Uk2LpbyXYtix7Z12lXgu0 /dbDa9FCJhmoKABhNEUdxSfIQGOb3vgNUTRJ3RTheyeUVK9PPVpmP0uKtDmsh/sM maf9xB1YL9+BAyHVTBB2r2dRE6rrmyzPs/qwCX3ertaDXZrfyADk3nMZWozknDKz 7Kc1oOOiq3QRs13NcoZ3DUpq3dB/lRk+CNQSrt/8czJ/U2jlYssNJvYHb27TgsIG yoUPzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FKwIYbsOXqXtMTdr4wHrazWNfBdaldr0arvyiWK1w ds=; b=XP1fNQIHuUiA4XZUkycayQ9pAiagchiCEnZGdKuNJG79ioydQ9XcMt8b+ v/B3cK6Ey/SiOxlN8dMudbILEzgUiEf+Uo5NcS7Nwo5OpgTiJSBSrMS+Z25jMlde a+7iNvlKK9cQw09kya/dPuFEGHwOuHAoXjI5d3Igt92vUv3KiCisW/mHVI8SlKxO JrDtk6TjI2DfFxV1/TqqJVH6x9VyEJWphPmD5SUuy7Jwf40BbwH/syjPVfDGnqeB +7BCr6D4TR5dzm3qRbb9RwY31FshAkTa3T2zJWpmBIN1VrJQxJm1y89YZZgSTBy7 /EMgiD0aqF/SlsOWVJkLobqFERePQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 56FDE24005E; Wed, 21 Apr 2021 14:27:07 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Wed, 21 Apr 2021 20:27:06 +0200 Message-ID: <5999123.3RDrOkptSD@thomas> In-Reply-To: <1618972783-22453-1-git-send-email-humin29@huawei.com> References: <1618972783-22453-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2021 04:39, Min Hu (Connor): > From: Chengwen Feng > > The new_mtu was assigned twice, the first assignment could be removed. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > - new_mtu = atoi(params->opt); > new_mtu = strtoul(params->opt, &ptr_parse_end, 10); Indeed, it looks useless. Applied, thanks.