* [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment
@ 2021-04-21 2:39 Min Hu (Connor)
2021-04-21 18:27 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 2:39 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
From: Chengwen Feng <fengchengwen@huawei.com>
The new_mtu was assigned twice, the first assignment could be removed.
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/ethtool/ethtool-app/ethapp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c
index e6c93e1..36a1c37 100644
--- a/examples/ethtool/ethtool-app/ethapp.c
+++ b/examples/ethtool/ethtool-app/ethapp.c
@@ -528,7 +528,6 @@ pcmd_mtu_callback(void *ptr_params,
printf("Error: Invalid port number %i\n", params->port);
return;
}
- new_mtu = atoi(params->opt);
new_mtu = strtoul(params->opt, &ptr_parse_end, 10);
if (*ptr_parse_end != '\0' ||
new_mtu < RTE_ETHER_MIN_MTU ||
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment
2021-04-21 2:39 [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment Min Hu (Connor)
@ 2021-04-21 18:27 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-04-21 18:27 UTC (permalink / raw)
To: Min Hu (Connor); +Cc: dev, ferruh.yigit
21/04/2021 04:39, Min Hu (Connor):
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> The new_mtu was assigned twice, the first assignment could be removed.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> - new_mtu = atoi(params->opt);
> new_mtu = strtoul(params->opt, &ptr_parse_end, 10);
Indeed, it looks useless.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 2:39 [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment Min Hu (Connor)
2021-04-21 18:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).