From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7C9D068A7 for ; Mon, 3 Mar 2014 18:15:57 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 03 Mar 2014 09:16:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,578,1389772800"; d="scan'208";a="491381154" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 03 Mar 2014 09:16:05 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.84]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0123.003; Mon, 3 Mar 2014 17:14:45 +0000 From: "Richardson, Bruce" To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev Thread-Index: AQHPNKpSyTpMf3gRPECQreF/ErT1eZrPnGQw Date: Mon, 3 Mar 2014 17:14:44 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01A9A16C7@IRSMSX103.ger.corp.intel.com> References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <1393608350-4431-10-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1393608350-4431-10-git-send-email-olivier.matz@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2014 17:15:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, February 28, 2014 5:26 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal > option by pci-whitelist and vdev >=20 > This commit splits the "--use-device" option in two new options: >=20 > - "--pci-whitelist or -w": add a PCI device in the white list > - "--vdev": instanciate a new virtual device >=20 > Before the patch, the same option "--use-device" was used for these 2 use= - > cases. [BR] Reviewing the patch set, most of the changes make sense to me. This on= e I've a few comments on.=20 Is it really necessary and beneficial to split the --use-device option into= two, and have two different ways for specifying the devices to use, based = on whether they are pci or virtual devices? An alternative suggestion/idea:= keep a common flag (be it --use-device, or something else) to specify a de= vice to use and that device's parameters, for all device types, pretty much= as now. Then, to solve the issue of not being able to use blacklisting plu= s virtual devices, that could be solved by adding the --pci-whitelist like = you suggest, except instead of specifying the devices there, it simply mean= s that only the pci devices passed to use-device get used. Without --pci-wh= itelist, all pci devices get used, whether or not they are explicitly calle= d out with --use-device? In this case, the "-b" flag could also be aliased by an "--ignore-device" (= or similar) flag. Any other thoughts or suggestions?