From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev
Date: Tue, 4 Mar 2014 13:14:17 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <5315D081.20506@6wind.com>
>
> My initial concern was that --use-device has 2 different significations,
> depending on the format of arguments:
> - instanciate a virtual driver if it looks like a vdev name
> - add a PCI device to the whitelist if it looks like a pci address I also find
> strange that instanciating a virtual device changes the PCI mode to
> whitelist, even if it could be fixed by adding a specific argument for that.
>
[BR] I agree that having the mode change silently like that was probably not the best design. I therefore, agree that a flag should be used to switch from normal to whitelist mode, I just think that thereafter the devices of whatever type should all be enumerated using a common flag parameter.
> Splitting into two different options looked clearer to me, but this is of
> course not a blocking issue for me.
>
[BR] For me neither, just giving my 2c worth :-).
next prev parent reply other threads:[~2014-03-04 13:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 17:25 [dpdk-dev] [PATCH 00/11] eal: allow virtual pmd drivers as shared lib Olivier Matz
2014-02-28 17:25 ` [dpdk-dev] [PATCH 01/11] mk: use whole-archive option when creating dpdk binaries Olivier Matz
2014-04-10 13:58 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 02/11] devices-args: introduce rte_devargs in eal Olivier Matz
2014-02-28 21:39 ` Stephen Hemminger
2014-03-01 12:02 ` Olivier MATZ
2014-03-01 12:14 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2014-04-10 13:59 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 03/11] devices-args: use rte_devargs and remove old whitelist code Olivier Matz
2014-03-01 12:14 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2014-04-10 14:01 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 04/11] devices-args: add a dump_devargs command in basic test application Olivier Matz
2014-04-10 14:02 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 05/11] pci: rename device_list as pci_device_list Olivier Matz
2014-04-10 14:03 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 06/11] vdev: rename eal_common_nonpci_devs.c as eal_common_vdev.c Olivier Matz
2014-04-10 14:39 ` Thomas Monjalon
2014-04-11 7:36 ` [dpdk-dev] [PATCH v2 06/11] vdev: rename nonpci_devs as vdev Olivier Matz
2014-04-11 11:25 ` Thomas Monjalon
2014-04-11 11:45 ` [dpdk-dev] [PATCH v3 " Olivier Matz
2014-04-11 12:37 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 07/11] vdev: allow external registration of virtual device drivers Olivier Matz
2014-04-10 14:55 ` Thomas Monjalon
2014-04-11 7:36 ` [dpdk-dev] [PATCH v2 07/11 1/2] vdev: new registration API Olivier Matz
2014-04-11 7:36 ` [dpdk-dev] [PATCH v2 07/11 2/2] vdev: allow external registration of virtual device drivers Olivier Matz
2014-04-11 14:31 ` Thomas Monjalon
2014-04-11 10:49 ` [dpdk-dev] [PATCH v2 07/11 1/2] vdev: new registration API Neil Horman
2014-04-11 13:11 ` Thomas Monjalon
2014-04-11 15:50 ` Neil Horman
2014-04-11 16:18 ` Thomas Monjalon
2014-04-11 17:44 ` Neil Horman
2014-04-11 20:08 ` Richardson, Bruce
2014-04-12 6:05 ` Thomas Monjalon
2014-04-12 11:03 ` Neil Horman
2014-04-12 11:23 ` Richardson, Bruce
2014-04-12 14:06 ` Neil Horman
2014-04-14 13:20 ` John W. Linville
2014-04-14 13:45 ` Thomas Monjalon
2014-04-14 13:54 ` Neil Horman
2014-04-14 14:10 ` John W. Linville
2014-04-14 14:39 ` Thomas Monjalon
2014-04-11 14:31 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 08/11] device-args: use a comma instead of semicolon to separate key/values Olivier Matz
2014-04-10 14:05 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev Olivier Matz
2014-03-01 12:14 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2014-04-10 14:06 ` Thomas Monjalon
2014-03-03 17:14 ` [dpdk-dev] [PATCH " Richardson, Bruce
2014-03-04 13:09 ` Olivier MATZ
2014-03-04 13:14 ` Richardson, Bruce [this message]
2014-03-24 22:39 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 10/11] device-args: allow to provide per pci device command line arguments Olivier Matz
2014-03-01 12:14 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2014-04-10 14:06 ` Thomas Monjalon
2014-02-28 17:25 ` [dpdk-dev] [PATCH 11/11] testpmd: add several dump commands, useful for debug Olivier Matz
2014-03-01 12:15 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2014-04-10 14:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).