From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9C6D76893 for ; Tue, 4 Mar 2014 14:13:03 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 04 Mar 2014 05:14:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,585,1389772800"; d="scan'208";a="492066687" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 04 Mar 2014 05:14:19 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 4 Mar 2014 13:14:17 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.84]) by IRSMSX151.ger.corp.intel.com ([169.254.4.2]) with mapi id 14.03.0123.003; Tue, 4 Mar 2014 13:14:17 +0000 From: "Richardson, Bruce" To: Olivier MATZ Thread-Topic: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev Thread-Index: AQHPNKpSyTpMf3gRPECQreF/ErT1eZrPnGQwgAFQMYCAAACcoA== Date: Tue, 4 Mar 2014 13:14:17 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01A9A1AC3@IRSMSX103.ger.corp.intel.com> References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <1393608350-4431-10-git-send-email-olivier.matz@6wind.com> <59AF69C657FD0841A61C55336867B5B01A9A16C7@IRSMSX103.ger.corp.intel.com> <5315D081.20506@6wind.com> In-Reply-To: <5315D081.20506@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2014 13:13:04 -0000 >=20 > My initial concern was that --use-device has 2 different significations, > depending on the format of arguments: > - instanciate a virtual driver if it looks like a vdev name > - add a PCI device to the whitelist if it looks like a pci address I a= lso find > strange that instanciating a virtual device changes the PCI mode to > whitelist, even if it could be fixed by adding a specific argument for th= at. >=20 [BR] I agree that having the mode change silently like that was probably no= t the best design. I therefore, agree that a flag should be used to switch = from normal to whitelist mode, I just think that thereafter the devices of = whatever type should all be enumerated using a common flag parameter. > Splitting into two different options looked clearer to me, but this is of > course not a blocking issue for me. >=20 [BR] For me neither, just giving my 2c worth :-).