From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D573A6895 for ; Wed, 14 May 2014 12:53:05 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 14 May 2014 03:53:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,1051,1389772800"; d="scan'208";a="540181887" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 14 May 2014 03:52:21 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 14 May 2014 11:51:29 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.183]) by IRSMSX106.ger.corp.intel.com ([169.254.8.28]) with mapi id 14.03.0123.003; Wed, 14 May 2014 11:51:29 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] mk: allow updates to build config on make install Thread-Index: AQHPb155tyJSpP5qkEqWi7EFw3B+zJs/0HcAgAATmLA= Date: Wed, 14 May 2014 10:51:28 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA196E4@IRSMSX103.ger.corp.intel.com> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> <3983181.2kuc6T3mxt@xps13> In-Reply-To: <3983181.2kuc6T3mxt@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 10:53:06 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, May 14, 2014 11:34 AM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make > install >=20 > Hi Bruce >=20 > 2014-05-14 11:22, Bruce Richardson: > > There was an issue with rebuilding the code following a change to one > > of the config files inside the "config" directory. If one did a "make > > install T=3D" and then made a modification to the > > defconfig_ file (or applied a patch which modified that file) > > a subsequent re-run of the make install command would not rebuild the > > .config file leading to either build failures or an incorrect build. > > This change fixes that issue. >=20 > Your patch is reverting this one: > mk: in install rule, don't overwrite .config if it already exists > http://dpdk.org/browse/dpdk/commit/?id=3D1c858a7dfebd4e4092eb55 > As stated in the commit log, > "This allows the user to prepare a configuration with make config > before using make install." >=20 > So your patch is introducing a regression. >=20 > I think you are describing something which is not a bug. > If you make a modification to the configuration template, you must explic= itly > call "make config". >=20 Ok, thanks for that Thomas.=20 However, I still think we have a bug here, or at least we need some discuss= ion on the correct behaviour we expect to have. From my point of view, the = new behaviour is problematic, as every time I apply a patch or do a pull, I= need to do a "make uninstall" or "make config" before doing "make install"= just in case something has changed in the defconfig file, even if I have c= hanged nothing on my end. This is not expected behaviour: if a change is ma= de to the repository, doing a rebuild should rebuild everything which need= s to be built to take account of that change. Regards, /Bruce