From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id DEA7336E for ; Wed, 14 May 2014 14:34:28 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 14 May 2014 05:34:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,1051,1389772800"; d="scan'208";a="432008582" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by azsmga001.ch.intel.com with ESMTP; 14 May 2014 05:34:32 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.183]) by IRSMSX101.ger.corp.intel.com ([169.254.1.249]) with mapi id 14.03.0123.003; Wed, 14 May 2014 13:33:10 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] mk: allow updates to build config on make install Thread-Index: AQHPb155tyJSpP5qkEqWi7EFw3B+zJs/0HcAgAATmLCAAANIAIAAFQtg Date: Wed, 14 May 2014 12:33:09 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA19761@IRSMSX103.ger.corp.intel.com> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> <3983181.2kuc6T3mxt@xps13> <59AF69C657FD0841A61C55336867B5B01AA196E4@IRSMSX103.ger.corp.intel.com> <1725713.WtaYEVcYoT@xps13> In-Reply-To: <1725713.WtaYEVcYoT@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 12:34:29 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, May 14, 2014 12:56 PM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make > install >=20 >=20 > You would like to have a synchronization of your generated .config file w= ith the > configuration template. But it's not possible for the simple reason that = you may > have modified your .config file so there is no simple correlation with th= e original > template. >=20 Would you agree then that the ideal state matrix for a make install should = probably be: * template unmodified, config unmodified - No issue - regenerate or not as = best suits the code * template unmodified, config modified - don't regenerate, keep local confi= g * template modified, config modified - flag an error, since continuing comp= ile with old config on new code will lead to undefined build results, since= config template changes rarely occur without code changes to go with them. * template modified, config unmodified - regenerate new config, overwriting= old one, for the same reason above. [Optionally print out message stating = that the config is being regenerated] Does this seem reasonable to you? The last case is the common case for me i= n development, as I've had multiple build errors and unexpected build resul= ts in the last week alone due to config template changes not propagating as= I switch development branches to work on different features. /Bruce