From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C790AFCF for ; Wed, 28 May 2014 10:49:33 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 28 May 2014 01:49:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,926,1392192000"; d="scan'208";a="547671725" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 28 May 2014 01:49:43 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX101.ger.corp.intel.com ([169.254.1.245]) with mapi id 14.03.0123.003; Wed, 28 May 2014 09:48:29 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 0/4] New library: rte_distributor Thread-Index: AQHPdBJ9PtpJ6FkU3k+uqZChiy9wXJtU/jwAgAC8YmA= Date: Wed, 28 May 2014 08:48:28 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA2EF6F@IRSMSX103.ger.corp.intel.com> References: <1400580057-30155-1-git-send-email-bruce.richardson@intel.com> <5389412.OPcvyX8cEM@xps13> In-Reply-To: <5389412.OPcvyX8cEM@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2014 08:49:34 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, May 27, 2014 11:33 PM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor >=20 > Hi Bruce, >=20 > As for rte_acl, I have some formatting comments. >=20 > 2014-05-20 11:00, Bruce Richardson: > > This adds a new library to the Intel DPDK whereby a set of packets can = be > > distributed one-at-a-time to a set of worker cores, with dynamic load > > balancing being done between those workers. Flows are identified by a t= ag > > within the mbuf (currently the RSS hash field, 32-bit value), which is = used > > to ensure that no two packets of the same flow are processed in paralle= l, > > thereby preserving ordering. > > > > app/test/Makefile | 2 + > > app/test/commands.c | 7 +- > > app/test/test.h | 2 + > > app/test/test_distributor.c | 582 +++++++++++++++++= ++++++++ > > app/test/test_distributor_perf.c | 274 ++++++++++++ > > config/defconfig_i686-default-linuxapp-gcc | 5 + > > config/defconfig_i686-default-linuxapp-icc | 5 + > > config/defconfig_x86_64-default-bsdapp-gcc | 6 + > > config/defconfig_x86_64-default-linuxapp-gcc | 5 + > > config/defconfig_x86_64-default-linuxapp-icc | 5 + > > lib/Makefile | 1 + > > lib/librte_distributor/Makefile | 50 +++ > > lib/librte_distributor/rte_distributor.c | 417 +++++++++++++++++= + > > lib/librte_distributor/rte_distributor.h | 173 ++++++++ > > lib/librte_eal/common/include/rte_tailq_elem.h | 2 + > > mk/rte.app.mk | 4 + > > 16 files changed, 1539 insertions(+), 1 deletion(-) >=20 > As you are introducing a new library, you need to update > doxygen configuration and start page: > doc/doxy-api.conf > doc/doxy-api-index.md Didn't know to update those, I'll add it in to the v2 patch set. >=20 > I've run checkpatch.pl from kernel.org on these distributor patches > and it reports some code style issues. > Could you have a look at it please? Yep. I've downloaded and run that patch myself in preparation for a V2 patc= h set (due really soon), so hopefully all should be well second time round.