From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 44320B0A6 for ; Tue, 10 Jun 2014 18:29:26 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 10 Jun 2014 09:29:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="353095308" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jun 2014 09:25:48 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 10 Jun 2014 17:29:38 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX151.ger.corp.intel.com ([169.254.4.152]) with mapi id 14.03.0123.003; Tue, 10 Jun 2014 17:29:38 +0100 From: "Richardson, Bruce" To: Olivier MATZ , Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] mk: allow updates to build config on make install Thread-Index: AQHPhLMvUGHnMNKD202osQ+Llg/rmptqcKoAgAAXudA= Date: Tue, 10 Jun 2014 16:29:37 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA3475A@IRSMSX103.ger.corp.intel.com> References: <537B3E91.4030400@6wind.com> <1402408293-19426-1-git-send-email-thomas.monjalon@6wind.com> <53972C24.1040305@6wind.com> In-Reply-To: <53972C24.1040305@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 16:29:26 -0000 Yes, good point. I'll try and redraft a v3 of the patch (thanks Thomas for = doing a V2), with that in it. I also think if we keep everything in the bui= ld dir we should not the rm afterwards. [In my previous tests when doing V1= patch, I found that deleting the directory each time seemed to slow things= down for the next run. I'll test if that is still the case when doing V3] > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier MATZ > Sent: Tuesday, June 10, 2014 9:03 AM > To: Thomas Monjalon; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] mk: allow updates to build config on m= ake > install >=20 > Hi Thomas, >=20 > On 06/10/2014 03:51 PM, Thomas Monjalon wrote: > > + if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \ > > + tmp_build=3D/tmp/dpdk-$*-$$$$; \ > > + $(MAKE) config T=3D$* O=3D$$(tmp_build); \ > > + if ! cmp -s $(BUILD_DIR)/$*/.config.orig > $$(tmp_build)/.config ; then \ > > + echo "Conflict: local config and template > config have both changed"; \ > > + exit 1; \ >=20 > I missed it the first time, but what do you think about using > $(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ? > I think using /tmp should be avoided when possible as it is a > shared folder. >=20 > Regards, > Olivier