From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6AD5FB0AD for ; Wed, 11 Jun 2014 17:25:37 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 11 Jun 2014 08:20:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,458,1400050800"; d="scan'208";a="555784025" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2014 08:25:44 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 11 Jun 2014 16:24:04 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX154.ger.corp.intel.com ([169.254.12.14]) with mapi id 14.03.0123.003; Wed, 11 Jun 2014 16:24:04 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] fix trailing whitespace. Thread-Index: AQHPf4Wz6cxLaAmW10KbllM6ob4TvJtj2ncAgAfOmgCAAGjvEA== Date: Wed, 11 Jun 2014 15:24:04 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA34EC5@IRSMSX103.ger.corp.intel.com> References: <1401838970-20968-1-git-send-email-bruce.richardson@intel.com> <20140606105032.GA1671@hmsreliant.think-freely.org> <87655757.0nh8hPpYoP@xps13> In-Reply-To: <87655757.0nh8hPpYoP@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fix trailing whitespace. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2014 15:25:37 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 11, 2014 3:04 AM > To: Richardson, Bruce > Cc: dev@dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH] fix trailing whitespace. >=20 > > > This commit removes trailing whitespace from lines in files. Almost a= ll > > > files are affected, as the BSD license copyright header had trailing > > > whitespace on 4 lines in it [hence the number of files reporting 8 li= nes > > > changed in the diffstat]. > > > > > > Signed-off-by: Bruce Richardson > > Acked-by: Neil Horman >=20 > I've completed it with these changes: > - remove spaces before tabs in libs > - remove more trailing spaces in non-C files >=20 > Applied for version 1.7.0. >=20 > Some whitespaces and indentation errors are remaining, especially in exam= ples. > But it can be fixed when examples will be updated. > I'm not a big fan of such patch. I prefer to take care of not adding new > spacing errors. So from now, trailing whitespaces, spaces before tabs > and wrong indentation should be tracked carefully in new patches. >=20 Just FYI: my reasoning for cleaning it up now is that it allows us to write= rules for our editors or IDEs to automatically fix whitespace errors on sa= ve (the patch I generated was created by using a vim rule on file save). Wi= thout having things cleaned up ahead of time, having a vim rule such as thi= s will cleanup each file as it is modified, leading to lots of extra whites= pace changes in our diffs, which are irrelevant to the code being changed. = This then makes our lives harder when working on patches. /Bruce