From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 36243B0A4
 for <dev@dpdk.org>; Wed, 11 Jun 2014 23:57:11 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 11 Jun 2014 14:57:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,460,1400050800"; d="scan'208";a="527065348"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga001.jf.intel.com with ESMTP; 11 Jun 2014 14:57:04 -0700
Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by
 IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Wed, 11 Jun 2014 22:57:03 +0100
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.197]) with mapi id 14.03.0123.003;
 Wed, 11 Jun 2014 22:57:03 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Lu, Patrick"
 <patrick.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] Add an API to query enabled core index
Thread-Index: AQHPhbfwu/CiTpgmaEuQDGPmRpHqN5tsYlCAgAASJgA=
Date: Wed, 11 Jun 2014 21:57:03 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B01AA35210@IRSMSX103.ger.corp.intel.com>
References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com>
 <9007853.cgh6aaULN3@xps13>
In-Reply-To: <9007853.cgh6aaULN3@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 21:57:11 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 11, 2014 2:51 PM
> To: Lu, Patrick
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
>=20
> Hi,
>=20
> 2014-06-11 13:45, Patrick Lu:
> > EAL -c option allows the user to enable any lcore in the system.
> > Oftentimes, the user app wants to know 1st enabled core, 2nd
> > enabled core, etc, rather than phyical core ID (rte_lcore_id().)
> >
> > The new API rte_lcore_id2() will return an index from enabled lcores
> > starting from zero.
>=20
> I think core_id2 is not a representative name.
> What do you think of renaming core_id as lcore_hwid and core_id2 as
> lcore_index?
>=20
> --
I like lcore_index as the name for the new function. However, I'm not sure =
in that case that we want/need to rename the old one.