From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 8198FB0CC
 for <dev@dpdk.org>; Thu, 12 Jun 2014 00:27:22 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 11 Jun 2014 15:22:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,460,1400050800"; d="scan'208";a="555982983"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga002.jf.intel.com with ESMTP; 11 Jun 2014 15:27:32 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.136]) with mapi id 14.03.0123.003;
 Wed, 11 Jun 2014 23:27:31 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions
Thread-Index: AQHPbciB4Jkeom3gb0qp2Y8gGXeFZ5tsmgmAgAASxfA=
Date: Wed, 11 Jun 2014 22:27:31 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B01AA35278@IRSMSX103.ger.corp.intel.com>
References: <1399888587-21068-1-git-send-email-bruce.richardson@intel.com>
 <3079600.trYA8PKFWl@xps13>
In-Reply-To: <3079600.trYA8PKFWl@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX
 functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 22:27:23 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, June 11, 2014 3:19 PM
> To: Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX
> functions
>=20
> Hi Bruce,
>=20
> You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
> I feel a comment in the code would be helpful here.

Comment in the code, or in the config file where the option is defined?

>=20
> Sorry for not having checked before but there are some checkpatch issues
> in this PMD.
> Other simple cleanup: I think some include directives are useless.
>=20
> Could you rework a new version please?
>=20
Ack. I'll see what I can do.