From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 89F66B10C for ; Thu, 12 Jun 2014 01:27:35 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 11 Jun 2014 16:27:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="353853091" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jun 2014 16:23:53 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX102.ger.corp.intel.com ([169.254.2.105]) with mapi id 14.03.0123.003; Thu, 12 Jun 2014 00:27:48 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] Add an API to query enabled core index Thread-Index: AQHPhbfwu/CiTpgmaEuQDGPmRpHqN5tsYlCAgAASJgD///5mAIAAGpuA Date: Wed, 11 Jun 2014 23:27:47 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA352EF@IRSMSX103.ger.corp.intel.com> References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com> <9007853.cgh6aaULN3@xps13> <59AF69C657FD0841A61C55336867B5B01AA35210@IRSMSX103.ger.corp.intel.com> <1487472.hZgYJQSpCy@xps13> In-Reply-To: <1487472.hZgYJQSpCy@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2014 23:27:36 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 11, 2014 3:50 PM > To: Richardson, Bruce > Cc: Lu, Patrick; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index >=20 > 2014-06-11 21:57, Richardson, Bruce: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > 2014-06-11 13:45, Patrick Lu: > > > > The new API rte_lcore_id2() will return an index from enabled lcore= s > > > > starting from zero. > > > > > > I think core_id2 is not a representative name. > > > What do you think of renaming core_id as lcore_hwid and core_id2 as > > > lcore_index? > > > > I like lcore_index as the name for the new function. However, I'm not s= ure > > in that case that we want/need to rename the old one. >=20 > I think it would be not easy to distinguish id and index. So I prefer > hwid/index. And lcore is more precise than core. >=20 The function is already called "rte_lcore_id()" so there is no need to chan= ge it to make it an "lcore" function. That function has been around for a l= ong time and is commonly used, so I'd prefer it not be changed unless it re= ally is necessary. "rte_lcore_index" is a sufficiently different function n= ame, in my opinion. The API documentation should clear up any confusion for= the user anyway.