From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B536CB0FE for ; Sat, 14 Jun 2014 02:07:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Jun 2014 17:07:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,474,1400050800"; d="scan'208";a="555367599" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 13 Jun 2014 17:07:10 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX104.ger.corp.intel.com ([169.254.5.136]) with mapi id 14.03.0123.003; Sat, 14 Jun 2014 01:07:10 +0100 From: "Richardson, Bruce" To: Thomas Monjalon , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCHv3 0/5] ACL library Thread-Index: AQHPhvp1Qw0jtBM78UyMjxq3/p8gI5tu3jyAgAABwICAAMJegIAAF6iw Date: Sat, 14 Jun 2014 00:07:09 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B01AA36227@IRSMSX103.ger.corp.intel.com> References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> <3012262.OhlkyXXJnt@xps13> <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com> <1541041.MVudaz1CFn@xps13> In-Reply-To: <1541041.MVudaz1CFn@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2014 00:07:11 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, June 13, 2014 4:38 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library >=20 > 2014-06-13 12:02, Ananyev, Konstantin: > > 2014-06-13 13:56, Thomas Monjalon: > > > > Konstantin Ananyev (5): > > > > Add ACL library (librte_acl) into DPDK > > > > acl: update UT to reflect latest changes in the librte_acl > > > > acl: New test-acl application > > > > acl: New sample l3fwd-acl > > > > acl: add doxygen configuration and start page > > > > > > > > v2 fixes: > > > > * Fixed several checkpatch.pl issues > > > > * Added doxygen related changes > > > > > > > > v3 fixes: > > > > * Fixed even more checkpatch.pl issues > > > > > > Sorry to bother you but after checking v3, > > > > > > I think these errors should be avoided: > > > ERROR: do not use assignment in if condition > > > ERROR: return is not a function, parentheses are not required > > > > These changes would require a lot of changes inside ACL library. > > As I said in cover letter, ACL library was part of IPL code for a while > > (nearly a year). > > I don't really want to make significant changes in it just before the > > release without really good reason - bugs found. >=20 > I've made the code style changes, move some configuration lines and added > to BSD build (not tested). > As it was previously acked and tested, > it is now applied for version 1.7.0. >=20 I'd be a bit wary about adding it to the BSD build. I'm only running BSD in= a VM here, but there GCC fails to recognise the processor supports SSE4 in= struction sets when using "-march=3Dnative", and so fails to compile the ve= ctor code - at least the vectorized PMD functions. That's why I've explicit= ly disabled those in the latest version of the vector PMD patch, and I woul= d suggest doing the same for the ACL code for now. Interestingly enough, in the same VM clang does seem to recognise SSE4. Out= put from the compilers below. Anyone with a physical box running BSD who co= uld confirm if this issue is localised to VMs or not? [bruce@BSD10-VM ~]$ gcc48 -dM -E -march=3Dnative - < /dev/null | grep SSE #define __SSE2_MATH__ 1 #define __SSE_MATH__ 1 #define __SSE2__ 1 #define __SSSE3__ 1 #define __SSE__ 1 #define __SSE3__ 1 [bruce@BSD10-VM ~]$ clang -dM -E -march=3Dnative - < /dev/null | grep SSE #define __SSE2_MATH__ 1 #define __SSE2__ 1 #define __SSE3__ 1 #define __SSE4_1__ 1 #define __SSE4_2__ 1 #define __SSE_MATH__ 1 #define __SSE__ 1 #define __SSSE3__ 1