From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 256BCB116 for ; Tue, 24 Jun 2014 20:01:04 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 24 Jun 2014 10:55:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,539,1400050800"; d="scan'208";a="533388902" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 24 Jun 2014 11:00:21 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 24 Jun 2014 19:00:21 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.31]) by IRSMSX106.ger.corp.intel.com ([169.254.8.192]) with mapi id 14.03.0123.003; Tue, 24 Jun 2014 19:00:21 +0100 From: "Richardson, Bruce" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf Thread-Index: AQHPj8Z6o21eKPs7QkGzW0cqTAffyJuAhm7A///z74CAABGnsA== Date: Tue, 24 Jun 2014 18:00:20 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B02CEE345B@IRSMSX103.ger.corp.intel.com> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> <20140624105427.166c21bf@nehalam.linuxnetplumber.net> In-Reply-To: <20140624105427.166c21bf@nehalam.linuxnetplumber.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 18:01:05 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, June 24, 2014 10:54 AM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf >=20 > On Tue, 24 Jun 2014 17:39:52 +0000 > "Richardson, Bruce" wrote: >=20 > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > Hemminger > > > Sent: Tuesday, June 24, 2014 9:03 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf > > > > > > The function rte_snprintf serves no useful purpose. It is the > > > same as snprintf() for all valid inputs. Just remove it and > > > replace all uses in current code. > > > > > > Signed-off-by: Stephen Hemminger > > > > > > > NAK to this as is. > > Approve of replacing all instance of the rte_snprintf function with the= standard > version in all our code and libraries. > > However, rather than just removing the function completely, I think we = should > just flag the function as deprecated initially, and then later on look to= remove it > completely. > > > > /Bruce >=20 > I want to get it out now rather than some 2 year life cycle. > The issue was discussed and marking it as deprecated breaks the build. > Alternate is removing all instances and adding: >=20 > #define rte_snprintf snprintf >=20 > in header file for user compatiablity. We can remove it from all our apps and then mark as deprecated and all our = code would still build. An interesting point I'd never thought of is, is it right for us to force u= ser apps to treat all warnings as errors? Perhaps we should also consider r= emoving -Werror from the CFLAGS when using rte.extapp.mk.