DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC
Date: Wed, 25 Jun 2014 17:26:23 +0000	[thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B02CEE4BC3@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE32E4@IRSMSX103.ger.corp.intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Richardson, Bruce
> Sent: Tuesday, June 24, 2014 10:22 AM
> To: Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Tuesday, June 24, 2014 2:39 AM
> > To: Richardson, Bruce
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC
> >
> > Hi Bruce,
> >
> > 2014-06-24 01:23, Bruce Richardson:
> > > when overriding the CC variable on the commandline, the HOSTCC value
> > > was remaining at "gcc", which caused errors on Free BSD10 when using a gcc
> > > as e.g. gcc48, without a binary just called "gcc". This change overrides
> > > HOSTCC when CC is overridden, which means that setting CC=gcc48, will
> > > now also set HOSTCC=gcc48, allowing the "testhost" app to compile on
> BSD10
> >
> > So you are mixing CC and HOSTCC which would break cross-compilation.
> > Why don't you set HOSTCC on command line?
> >
> 
> Because I shouldn't need to set HOSTCC unless I am cross compiling and need a
> different CC and HOSTCC. If my compiler is called "gcc48", and I tell the build
> system that my compiler is called "gcc48", it should use that value everywhere in
> place of gcc, unless I also tell it that my HOSTCC should be something
> completely different. This patch only affects HOSTCC if you specify CC on the
> command-line to override that value, otherwise things are left as they are.
> If you do want to override CC and do cross compiling with a separate HOSTCC
> that can be done too, by overriding HOSTCC also, i.e. CC=x HOSTCC=y. For those
> not cross compiling, they should never need to know about HOSTCC at all.

Is the above explanation clear enough? Anyone any other comments or care to ack the patch. I think this is really needed to make it easy to use v1.7 on BSD 10, which has no gcc by default.

/Bruce

  reply	other threads:[~2014-06-25 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  0:23 [dpdk-dev] [PATCH 0/2] minor compile fixes for FreeBSD 10 Bruce Richardson
2014-06-24  0:23 ` [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC Bruce Richardson
2014-06-24  9:38   ` Thomas Monjalon
2014-06-24 17:22     ` Richardson, Bruce
2014-06-25 17:26       ` Richardson, Bruce [this message]
2014-06-24  0:23 ` [dpdk-dev] [PATCH 2/2] bsdapp: disable ACL library compilation Bruce Richardson
2014-06-27  0:47 ` [dpdk-dev] [PATCH 0/2] minor compile fixes for FreeBSD 10 Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59AF69C657FD0841A61C55336867B5B02CEE4BC3@IRSMSX104.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).