From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E20F2AFCF for ; Wed, 25 Jun 2014 19:26:25 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 25 Jun 2014 10:26:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,547,1400050800"; d="scan'208";a="553214879" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 25 Jun 2014 10:26:26 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 25 Jun 2014 18:26:24 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.106]) by IRSMSX153.ger.corp.intel.com ([169.254.9.233]) with mapi id 14.03.0123.003; Wed, 25 Jun 2014 18:26:23 +0100 From: "Richardson, Bruce" To: "Richardson, Bruce" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC Thread-Index: AQHPj0KGbYVJKfCb8ECM9/LVVEWXZZt/8PSAgACOexCAAZb48A== Date: Wed, 25 Jun 2014 17:26:23 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B02CEE4BC3@IRSMSX104.ger.corp.intel.com> References: <1403569384-16758-1-git-send-email-bruce.richardson@intel.com> <1403569384-16758-2-git-send-email-bruce.richardson@intel.com> <3326698.g5GoIMb4bc@xps13> <59AF69C657FD0841A61C55336867B5B02CEE32E4@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE32E4@IRSMSX103.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 17:26:26 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Richardson, Bruce > Sent: Tuesday, June 24, 2014 10:22 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOST= CC >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, June 24, 2014 2:39 AM > > To: Richardson, Bruce > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HO= STCC > > > > Hi Bruce, > > > > 2014-06-24 01:23, Bruce Richardson: > > > when overriding the CC variable on the commandline, the HOSTCC value > > > was remaining at "gcc", which caused errors on Free BSD10 when using = a gcc > > > as e.g. gcc48, without a binary just called "gcc". This change overri= des > > > HOSTCC when CC is overridden, which means that setting CC=3Dgcc48, wi= ll > > > now also set HOSTCC=3Dgcc48, allowing the "testhost" app to compile o= n > BSD10 > > > > So you are mixing CC and HOSTCC which would break cross-compilation. > > Why don't you set HOSTCC on command line? > > >=20 > Because I shouldn't need to set HOSTCC unless I am cross compiling and ne= ed a > different CC and HOSTCC. If my compiler is called "gcc48", and I tell the= build > system that my compiler is called "gcc48", it should use that value every= where in > place of gcc, unless I also tell it that my HOSTCC should be something > completely different. This patch only affects HOSTCC if you specify CC on= the > command-line to override that value, otherwise things are left as they ar= e. > If you do want to override CC and do cross compiling with a separate HOST= CC > that can be done too, by overriding HOSTCC also, i.e. CC=3Dx HOSTCC=3Dy. = For those > not cross compiling, they should never need to know about HOSTCC at all. Is the above explanation clear enough? Anyone any other comments or care to= ack the patch. I think this is really needed to make it easy to use v1.7 o= n BSD 10, which has no gcc by default. /Bruce