From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 90C81AFDD for ; Thu, 26 Jun 2014 17:11:35 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 26 Jun 2014 08:11:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,553,1400050800"; d="scan'208";a="561368839" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 26 Jun 2014 08:11:52 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 26 Jun 2014 16:09:02 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.130]) by IRSMSX152.ger.corp.intel.com ([169.254.6.25]) with mapi id 14.03.0123.003; Thu, 26 Jun 2014 16:09:02 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf Thread-Index: AQHPj8Z6o21eKPs7QkGzW0cqTAffyJuAhm7AgADpawCAAhCXMA== Date: Thu, 26 Jun 2014 15:09:01 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> <12214985.ClK2CaJOyY@xps13> In-Reply-To: <12214985.ClK2CaJOyY@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2014 15:11:36 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 25, 2014 1:33 AM > To: Richardson, Bruce > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf >=20 > 2014-06-24 17:39, Richardson, Bruce: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > > The function rte_snprintf serves no useful purpose. It is the > > > same as snprintf() for all valid inputs. Just remove it and > > > replace all uses in current code. > > > > NAK to this as is. > > Approve of replacing all instance of the rte_snprintf function with the > > standard version in all our code and libraries. However, rather than ju= st > > removing the function completely, I think we should just flag the funct= ion > > as deprecated initially, and then later on look to remove it completely= . >=20 > I agree we should try to use the "deprecated" attribute when possible. > So application porting effort will be smoother. >=20 > But in this case, there is something different: as Stephen wrote, rte_snp= rintf > is useless. It's useless inside the DPDK so it's even more useless for us= er > applications. > As it's really useless, it has no sense to keep it as deprecated. > Please, let's simply remove it. >=20 The reason to keep it as deprecated is so that those customers who don't wa= nt to do a huge amount of search-replace immediately can get things working= again temporarily using -Wno-deprecated. It provides a simple temporary fa= llback cushion, and then we can completely remove the function later.=20 So, I'd like to see us remove all our usage of the function internally in 1= .7, along with marking as deprecated, and then completely remove in 1.8, (i= .e. in a week's time or so) :-)