From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"John W. Linville" <linville@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices
Date: Fri, 11 Jul 2014 17:38:17 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0343ACEB1@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <4763701.40HJ79Bo5S@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, July 11, 2014 9:48 AM
> To: John W. Linville
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-
> based virtual devices
>
> 2014-07-11 11:30, John W. Linville:
> > On Fri, Jul 11, 2014 at 05:04:04PM +0200, Thomas Monjalon wrote:
> > > 2014-07-11 10:51, John W. Linville:
> > > > On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote:
> > > > > Thank you for this nice work.
> > > > >
> > > > > I think it would be well suited to host this PMD as an external one in
> > > > > order to make it work also with DPDK 1.7.0.
> > > >
> > > > I'm not sure I understand the suggestion -- you don't want to merge
> > > > the driver for 1.8? Or you just want to host this patch somewhere,
> > > > so people can still use it w/ 1.7?
> > >
> > > I suggest to have a separated repository here:
> > > http://dpdk.org/browse/
> >
> > I really don't see any reason not to merge it. It was already delayed
> > by me waiting for all the PMD init changes to settle out in the 1.6
> > release, and I still had to do a few touch-ups for it to compile on
> > 1.7. I definitely do not want to have to do that over and over again.
>
> It's a pity that we didn't synchronize our efforts to make it integrated
> during 1.7.0 cycle.
>
> > Why wouldn't you just merge it? If someone wants to use it on 1.7,
> > they can just apply the patch.
>
> I'm OK to merge it. I was only suggesting to host your PMD externally like we
> did for virtio-net-pmd, vmxnet3-usermap and memnic.
> It was the same discussion for the vmxnet3 PMD that Stephen submitted.
>
> I start thinking that nobody wants PMD to be external. So we may merge this
> one in dpdk.git and start talking what to do for the other ones:
> - move memnic in dpdk.git?
Yes, I would agree with this. Having drivers in external git repos makes it hard for us to take them into account when planning on making changes to the core libs.
> - move virtio-net-pmd and vmxnet3-usermap where sits their uio
> counterparts?
> - merge Brocade's vmxnet3 as new one or as a replacement for
> vmxnet3-uio?
For these we really should try and converge on a single solution. Having multiple vmxnet3 and virtio drivers duplicates effort and is just plain messy! Of course, that's easier to say than to agree on...
/Bruce
next prev parent reply other threads:[~2014-07-11 17:37 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 20:32 John W. Linville
2014-07-11 13:11 ` Stephen Hemminger
2014-07-11 14:49 ` John W. Linville
2014-07-11 15:06 ` Richardson, Bruce
2014-07-11 15:16 ` Stephen Hemminger
2014-07-11 16:07 ` Richardson, Bruce
2014-07-11 15:29 ` Venkatesan, Venky
2014-07-11 15:33 ` John W. Linville
2014-07-11 16:29 ` Venkatesan, Venky
2014-07-11 13:26 ` Thomas Monjalon
2014-07-11 14:51 ` John W. Linville
2014-07-11 15:04 ` Thomas Monjalon
2014-07-11 15:30 ` John W. Linville
2014-07-11 16:47 ` Thomas Monjalon
2014-07-11 17:38 ` Richardson, Bruce [this message]
2014-07-11 17:41 ` John W. Linville
2014-07-12 11:48 ` Neil Horman
[not found] ` <D0158A423229094DA7ABF71CF2FA0DA3117D3A23@shsmsx102.ccr.corp.intel.com>
2014-07-11 17:20 ` Zhou, Danny
2014-07-11 17:40 ` John W. Linville
2014-07-11 18:01 ` Zhou, Danny
2014-07-11 18:46 ` John W. Linville
2014-07-12 0:42 ` Zhou, Danny
2014-07-14 13:45 ` John W. Linville
2014-07-11 19:04 ` Zhou, Danny
2014-07-11 19:31 ` John W. Linville
2014-07-11 20:27 ` Zhou, Danny
2014-07-11 20:31 ` Shaw, Jeffrey B
2014-07-11 20:35 ` Zhou, Danny
2014-07-11 20:40 ` John W. Linville
2014-07-11 22:34 ` Thomas Monjalon
2014-07-14 13:46 ` John W. Linville
2014-07-15 21:27 ` Thomas Monjalon
2014-07-16 12:35 ` Neil Horman
2014-07-16 13:37 ` Thomas Monjalon
2014-07-16 14:07 ` John W. Linville
2014-07-16 14:26 ` Thomas Monjalon
2014-07-16 15:59 ` Shaw, Jeffrey B
2014-07-11 22:30 ` Thomas Monjalon
2014-07-14 17:53 ` John W. Linville
2014-07-11 22:51 ` Bruce Richardson
2014-07-14 13:48 ` John W. Linville
2014-07-14 17:35 ` John W. Linville
2014-07-14 18:24 ` [dpdk-dev] [PATCH v2] " John W. Linville
2014-07-15 0:15 ` Zhou, Danny
2014-07-15 12:17 ` Neil Horman
2014-07-15 14:01 ` John W. Linville
2014-07-15 15:40 ` Zhou, Danny
2014-07-15 19:08 ` John W. Linville
2014-07-15 20:31 ` Neil Horman
2014-07-15 20:41 ` Zhou, Danny
2014-07-15 15:34 ` Zhou, Danny
2014-09-12 18:05 ` John W. Linville
2014-09-12 18:31 ` Zhou, Danny
2014-09-12 18:54 ` John W. Linville
2014-09-12 20:35 ` Zhou, Danny
2014-09-15 15:09 ` Neil Horman
2014-09-15 15:15 ` John W. Linville
2014-09-15 15:43 ` Zhou, Danny
2014-09-15 16:22 ` Neil Horman
2014-09-15 17:48 ` John W. Linville
2014-09-15 19:11 ` Zhou, Danny
2014-09-16 20:16 ` Neil Horman
2014-09-26 9:28 ` Thomas Monjalon
2014-09-26 14:08 ` Neil Horman
2014-09-29 10:05 ` Bruce Richardson
2014-10-08 15:57 ` Thomas Monjalon
2014-10-08 19:14 ` Neil Horman
2014-11-13 10:03 ` Thomas Monjalon
2014-11-13 11:14 ` Neil Horman
2014-11-13 11:57 ` Thomas Monjalon
2014-11-14 0:42 ` Neil Horman
2014-11-14 14:45 ` John W. Linville
2014-11-17 15:57 ` [dpdk-dev] [PATCH v3] librte_pmd_af_packet: " John W. Linville
2014-11-24 16:16 ` Thomas Monjalon
2014-11-17 11:19 ` [dpdk-dev] [PATCH v2] librte_pmd_packet: " Neil Horman
2014-11-17 11:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B0343ACEB1@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).