From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 43E06B3B0 for ; Fri, 11 Jul 2014 19:37:52 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 11 Jul 2014 10:38:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,644,1400050800"; d="scan'208";a="455993861" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by azsmga001.ch.intel.com with ESMTP; 11 Jul 2014 10:38:18 -0700 Received: from irsmsx109.ger.corp.intel.com (163.33.3.23) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 11 Jul 2014 18:38:18 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by IRSMSX109.ger.corp.intel.com ([169.254.13.142]) with mapi id 14.03.0123.003; Fri, 11 Jul 2014 18:38:17 +0100 From: "Richardson, Bruce" To: Thomas Monjalon , "John W. Linville" Thread-Topic: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices Thread-Index: AQHPnSipFRZOpvOWmkiHlCEtQVBhS5ubIoug Date: Fri, 11 Jul 2014 17:38:17 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343ACEB1@IRSMSX103.ger.corp.intel.com> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <1669414.yQGOz8cIDY@xps13> <20140711153006.GC25478@tuxdriver.com> <4763701.40HJ79Bo5S@xps13> In-Reply-To: <4763701.40HJ79Bo5S@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2014 17:37:52 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, July 11, 2014 9:48 AM > To: John W. Linville > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET- > based virtual devices >=20 > 2014-07-11 11:30, John W. Linville: > > On Fri, Jul 11, 2014 at 05:04:04PM +0200, Thomas Monjalon wrote: > > > 2014-07-11 10:51, John W. Linville: > > > > On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote: > > > > > Thank you for this nice work. > > > > > > > > > > I think it would be well suited to host this PMD as an external o= ne in > > > > > order to make it work also with DPDK 1.7.0. > > > > > > > > I'm not sure I understand the suggestion -- you don't want to merge > > > > the driver for 1.8? Or you just want to host this patch somewhere, > > > > so people can still use it w/ 1.7? > > > > > > I suggest to have a separated repository here: > > > http://dpdk.org/browse/ > > > > I really don't see any reason not to merge it. It was already delayed > > by me waiting for all the PMD init changes to settle out in the 1.6 > > release, and I still had to do a few touch-ups for it to compile on > > 1.7. I definitely do not want to have to do that over and over again. >=20 > It's a pity that we didn't synchronize our efforts to make it integrated > during 1.7.0 cycle. >=20 > > Why wouldn't you just merge it? If someone wants to use it on 1.7, > > they can just apply the patch. >=20 > I'm OK to merge it. I was only suggesting to host your PMD externally lik= e we > did for virtio-net-pmd, vmxnet3-usermap and memnic. > It was the same discussion for the vmxnet3 PMD that Stephen submitted. >=20 > I start thinking that nobody wants PMD to be external. So we may merge th= is > one in dpdk.git and start talking what to do for the other ones: > - move memnic in dpdk.git? Yes, I would agree with this. Having drivers in external git repos makes it= hard for us to take them into account when planning on making changes to t= he core libs. > - move virtio-net-pmd and vmxnet3-usermap where sits their uio > counterparts? > - merge Brocade's vmxnet3 as new one or as a replacement for > vmxnet3-uio? For these we really should try and converge on a single solution. Having mu= ltiple vmxnet3 and virtio drivers duplicates effort and is just plain messy= ! Of course, that's easier to say than to agree on... /Bruce