From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Matthew Hall <mhall@mhcomputing.net>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl
Date: Mon, 21 Jul 2014 17:37:49 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0343B0E8C@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1405914461-19335-2-git-send-email-mhall@mhcomputing.net>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall
> Sent: Sunday, July 20, 2014 8:48 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl
>
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> ---
> examples/l3fwd/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/examples/l3fwd/Makefile b/examples/l3fwd/Makefile
> index 68de8fc..5cd7396 100644
> --- a/examples/l3fwd/Makefile
> +++ b/examples/l3fwd/Makefile
> @@ -46,6 +46,7 @@ SRCS-y := main.c
>
> CFLAGS += -O3 $(USER_FLAGS)
> CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -Wno-unused-function
>
Rather than disabling the warnings, would it not be better to remove the functions entirely from the compile? I would assume that these are functions for one leg of the l3fwd code (e.g. hash lookup vs lpm lookup) that are not used in the other leg of the code, in which case the proper fix should be to add some more #ifdefs, right?
/Bruce
next prev parent reply other threads:[~2014-07-21 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 3:47 [dpdk-dev] [PATCH] examples: fix clang compilation issues Matthew Hall
2014-07-21 3:47 ` [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl Matthew Hall
2014-07-21 13:44 ` Thomas Monjalon
2014-07-21 16:53 ` Matthew Hall
2014-07-21 17:37 ` Richardson, Bruce [this message]
2014-07-21 3:47 ` [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around equality check Matthew Hall
2014-07-22 13:14 ` Thomas Monjalon
2014-07-22 19:27 ` Matthew Hall
2014-07-21 3:47 ` [dpdk-dev] [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's Matthew Hall
2014-07-21 13:45 ` Thomas Monjalon
2014-07-21 3:47 ` [dpdk-dev] [PATCH 4/4] rte.extvars.mk: allow user to override RTE_SDK_BIN Matthew Hall
2014-07-21 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B0343B0E8C@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mhall@mhcomputing.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).