From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 57824595A
 for <dev@dpdk.org>; Mon, 21 Jul 2014 19:36:48 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 21 Jul 2014 10:38:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,702,1400050800"; d="scan'208";a="573190568"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga002.fm.intel.com with ESMTP; 21 Jul 2014 10:38:01 -0700
Received: from irsmsx107.ger.corp.intel.com (163.33.3.99) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Mon, 21 Jul 2014 18:37:49 +0100
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.112]) with mapi id 14.03.0123.003;
 Mon, 21 Jul 2014 18:37:49 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Matthew Hall <mhall@mhcomputing.net>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in
 l3fwd-acl
Thread-Index: AQHPpJdnpTbSOJKo3kiI4X4g1wvFMZuqy2IA
Date: Mon, 21 Jul 2014 17:37:49 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0343B0E8C@IRSMSX103.ger.corp.intel.com>
References: <1405914461-19335-1-git-send-email-mhall@mhcomputing.net>
 <1405914461-19335-2-git-send-email-mhall@mhcomputing.net>
In-Reply-To: <1405914461-19335-2-git-send-email-mhall@mhcomputing.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in
 l3fwd-acl
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2014 17:36:48 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall
> Sent: Sunday, July 20, 2014 8:48 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd=
-acl
>=20
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> ---
>  examples/l3fwd/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/examples/l3fwd/Makefile b/examples/l3fwd/Makefile
> index 68de8fc..5cd7396 100644
> --- a/examples/l3fwd/Makefile
> +++ b/examples/l3fwd/Makefile
> @@ -46,6 +46,7 @@ SRCS-y :=3D main.c
>=20
>  CFLAGS +=3D -O3 $(USER_FLAGS)
>  CFLAGS +=3D $(WERROR_FLAGS)
> +CFLAGS +=3D -Wno-unused-function
>=20

Rather than disabling the warnings, would it not be better to remove the fu=
nctions entirely from the compile? I would assume that these are functions =
for one leg of the l3fwd code (e.g. hash lookup vs lpm lookup) that are not=
 used in the other leg of the code, in which case the proper fix should be =
to add some more #ifdefs, right?

/Bruce