From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id E9CB868AE for ; Wed, 23 Jul 2014 20:40:32 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 23 Jul 2014 11:41:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,718,1400050800"; d="scan'208";a="460542376" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by azsmga001.ch.intel.com with ESMTP; 23 Jul 2014 11:41:55 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by IRSMSX102.ger.corp.intel.com ([169.254.2.76]) with mapi id 14.03.0123.003; Wed, 23 Jul 2014 19:41:53 +0100 From: "Richardson, Bruce" To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device Thread-Index: AQHPpnHM3IIXxTg8QUCCzBNtaLKkHput/oUA Date: Wed, 23 Jul 2014 18:41:53 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343B1737@IRSMSX103.ger.corp.intel.com> References: <1406118534-6169-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1406118534-6169-1-git-send-email-olivier.matz@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statistics of a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 18:40:33 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > Sent: Wednesday, July 23, 2014 5:29 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] introduce dev_ops to get extended statist= ics of > a device >=20 > The generic statistics structure is getting bigger as new statistics are > added in specific devices. For instance, fdir, tx_pause or loopback > stats do not apply on virtual devices. It won't be possible to add every > specific statistics in this generic stats structure, but on the other > hand these specific statistics are useful for debugging purpose. >=20 > This 2 patches introduces xstats_get() and xstats_reset() in > dev_ops. When registered by a device, it can be used to provide > arbitrary statistics that are identified by a name, as done by eththool > in kernel. >=20 > After that, some statistics could be moved from the generic structure to > this new framework, but it will be part of another patch series as it > should be discussed first. >=20 I like the idea, so Ack on the concept. :-)