DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Reduce compilation to only require sse3 intrinsics
Date: Fri, 1 Aug 2014 17:39:48 +0000	[thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0343D47DF@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1406911737-13362-1-git-send-email-nhorman@tuxdriver.com>

> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Friday, August 01, 2014 9:49 AM
> To: dev@dpdk.org
> Cc: Neil Horman; Ananyev, Konstantin; Richardson, Bruce; Thomas Monjalon
> Subject: [PATCH] ixgbe: Reduce compilation to only require sse3 intrinsics
> 
> ixgbe was failing to build in the default configuration because it required
> sse4.2 intrinsics, and the default config doesn't support more than sse3.
> Modify the pmd so that only sse3 intrinsics are pulled in and used.
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: "Konstantin Ananyev" <konstantin.ananyev@intel.com>
> CC: Bruce Richardson <bruce.richardson@intel.com>
> CC: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index 09e19a3..fe39ca2 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -38,7 +38,7 @@
>  #include "ixgbe_ethdev.h"
>  #include "ixgbe_rxtx.h"
> 
> -#include <nmmintrin.h>
> +#include <tmmintrin.h>
> 
>  #ifndef __INTEL_COMPILER
>  #pragma GCC diagnostic ignored "-Wcast-qual"
> @@ -338,7 +338,7 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> **rx_pkts,
>  				pkt_mb1);
> 
>  		/* C.4 calc avaialbe number of desc */
> -		var = _mm_popcnt_u64(_mm_cvtsi128_si64(staterr));
> +		var = __builtin_popcountll(_mm_cvtsi128_si64(staterr));
>  		nb_pkts_recd += var;
>  		if (likely(var != RTE_IXGBE_DESCS_PER_LOOP))
>  			break;
> --
> 1.8.3.1

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2014-08-01 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 16:48 Neil Horman
2014-08-01 17:39 ` Richardson, Bruce [this message]
2014-08-12 23:55   ` Thomas Monjalon
2014-08-13 10:11     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59AF69C657FD0841A61C55336867B5B0343D47DF@IRSMSX103.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).