From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CA170B39F
 for <dev@dpdk.org>; Tue, 12 Aug 2014 00:00:58 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 11 Aug 2014 15:03:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,844,1400050800"; d="scan'208";a="583415978"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 11 Aug 2014 15:03:49 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.131]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.12]) with mapi id 14.03.0195.001;
 Mon, 11 Aug 2014 23:03:48 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [RFC PATCH 11/14] ixgbe: make mbuf_initializer
 queue variable global
Thread-Index: AQHPtaUmLEMXHVG0R0K+HX9/gci0NJvL362AgAAU+uA=
Date: Mon, 11 Aug 2014 22:03:47 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0343D8937@IRSMSX103.ger.corp.intel.com>
References: <1407789890-17355-1-git-send-email-bruce.richardson@intel.com>
 <1407789890-17355-12-git-send-email-bruce.richardson@intel.com>
 <20140811144737.3ef08d36@haswell.linuxnetplumber.net>
In-Reply-To: <20140811144737.3ef08d36@haswell.linuxnetplumber.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH 11/14] ixgbe: make mbuf_initializer queue
 variable global
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Aug 2014 22:00:59 -0000


> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Monday, August 11, 2014 2:48 PM
> To: Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH 11/14] ixgbe: make mbuf_initializer qu=
eue
> variable global
>=20
> On Mon, 11 Aug 2014 21:44:47 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>=20
> > On descriptor rearm, the mbuf_initializer variable can be used to do a
> > single-shot write to an mbuf to initialize all variables that can be
> > set. This is currently used only by vector PMD function, but now allow
> > it to be generally used by other RX code paths.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx.c     | 25 +++++++++++++++++++++++--
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx.h     |  9 ++++++---
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 25 +------------------------
> >  3 files changed, 30 insertions(+), 29 deletions(-)
>=20
>=20
> These patches from 11-14 are really a follow on thread to the original
> changes. The sequence could be shorter so that reviewers digest 1-10 firs=
t.

Ok. The whole patch sequence needs to be cleaned up a lot before it's ready=
 to go into the code, so I'll try and keep that in mind when doing the clea=
nup.