From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6E84FB3BC for ; Tue, 12 Aug 2014 18:22:26 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 12 Aug 2014 09:25:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,849,1400050800"; d="scan'208";a="587075875" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 12 Aug 2014 09:25:19 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 12 Aug 2014 17:25:19 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.131]) by IRSMSX154.ger.corp.intel.com ([169.254.12.156]) with mapi id 14.03.0195.001; Tue, 12 Aug 2014 17:25:18 +0100 From: "Richardson, Bruce" To: Olivier MATZ Thread-Topic: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename RTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT Thread-Index: AQHPtaUhN4m7oQul1EulENGzNX7FrpvL3wuAgACrp4CAAJwbcA== Date: Tue, 12 Aug 2014 16:25:18 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343D8C21@IRSMSX103.ger.corp.intel.com> References: <1407789890-17355-1-git-send-email-bruce.richardson@intel.com> <1407789890-17355-2-git-send-email-bruce.richardson@intel.com> <20140811144521.21058e5b@haswell.linuxnetplumber.net> <53E9C96F.6050904@6wind.com> In-Reply-To: <53E9C96F.6050904@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename RTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 16:22:27 -0000 Ok, thanks, I'll see about fixing those. I see a number of comments about the format and structure of the patch set = itself. I'll take those all on board, but I'll admit that I didn't rework t= he patchset much before submitting it as an RFC. I'm leaving that until I'v= e finished on this and ready to start submitting non-RFC patchset for merge= . Right now my primary concern is whether the reworked struct rte_mbuf has = everything we need, and whether there are any performance regressions we ne= ed to fix due to the second cache line.=20 Regards, /Bruce > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, August 12, 2014 1:00 AM > To: Richardson, Bruce > Cc: Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename > RTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT >=20 > Hi Bruce, >=20 > On 08/11/2014 11:45 PM, Stephen Hemminger wrote: > > On Mon, 11 Aug 2014 21:44:37 +0100 > > Bruce Richardson wrote: > > > >> From: Olivier Matz > >> > >> It seems that RTE_MBUF_SCATTER_GATHER is not the proper name for the > >> feature it provides. "Scatter gather" means that data is stored using > >> several buffers. RTE_MBUF_REFCNT seems to be a better name for that > >> feature as it provides a reference counter for mbufs. > >> > >> The macro RTE_MBUF_SCATTER_GATHER is poisoned to ensure this > >> modification is seen by drivers or applications using it. > >> > >> Signed-off-by: Olivier Matz > >> Signed-off-by: Bruce Richardson >=20 > After applying this first patch, I still get references to > "scatter gather": >=20 > $ git grep RTE_MBUF_SCATTER_GATHER > examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) +=3D > ip_fragmentation > examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) +=3D > ipv4_multicast > examples/ip_fragmentation/Makefile:ifneq > ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) > examples/ip_fragmentation/Makefile:$(error This application requires > RTE_MBUF_SCATTER_GATHER to be enabled) > examples/ip_pipeline/Makefile:ifeq > ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) > lib/librte_mbuf/rte_mbuf.h:#pragma GCC poison RTE_MBUF_SCATTER_GATHER > lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) > lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) >=20 > Olivier