From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F24F23989 for ; Sun, 7 Sep 2014 21:35:23 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 07 Sep 2014 12:31:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="382697561" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2014 12:35:09 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sun, 7 Sep 2014 20:40:02 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by IRSMSX152.ger.corp.intel.com ([169.254.6.48]) with mapi id 14.03.0195.001; Sun, 7 Sep 2014 20:40:02 +0100 From: "Richardson, Bruce" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into mbuf struct Thread-Index: AQHPySVub/fa/VTREkqBfdqRu3OwlJv2E+lA Date: Sun, 7 Sep 2014 19:40:01 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343EF578@IRSMSX103.ger.corp.intel.com> References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> <1409240559-14447-7-git-send-email-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into mbuf struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 19:35:24 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, September 05, 2014 5:21 PM > To: Richardson, Bruce; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip in= to > mbuf struct >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, August 28, 2014 4:43 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into > > mbuf struct > > > > The vlan_macip structure combined a vlan tag id with l2 and l3 headers > > lengths for tracking offloads. However, this structure was only used as > > a unit by the e1000 and ixgbe drivers, not generally. > > > > This patch removes the structure from the mbuf header and places the > > fields into the mbuf structure directly at the required point, without > > any net effect on the structure layout. This allows us to treat the vla= n > > tags and header length fields as separate for future mbuf changes. The > > drivers which were written to use the combined structure still do so, > > using a driver-local definition of it. > > > > Changes in V2: > > * None > > > > Signed-off-by: Bruce Richardson >=20 > After applying this patch, I see a performance degradation (around 5%) us= ing > testpmd with the default RX path, so this may require a v3 patch. >=20 > Thanks, > Pablo Thanks for Pablo for flagging this. Since no fields are moved in the struct= ure, merely flattened, I suspect any degradation must come from having the = l2_len and l3_len bit fields split out. I'll do up a v3 with a union to all= ow them to be assigned simultaneously and see if it helps things. Fast-path= is unaffected in my tests. /Bruce