From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6AFDDB3AA for ; Tue, 9 Sep 2014 10:44:45 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 09 Sep 2014 01:49:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,491,1406617200"; d="scan'208";a="596702996" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 09 Sep 2014 01:49:23 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 9 Sep 2014 09:48:38 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by IRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id 14.03.0195.001; Tue, 9 Sep 2014 09:48:38 +0100 From: "Richardson, Bruce" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf Thread-Index: AQHPwta/R/ZLSlLyIU6bZkQjlXXcBZv25WuAgAGqPbA= Date: Tue, 9 Sep 2014 08:48:37 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343EFA22@IRSMSX103.ger.corp.intel.com> References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> <1409240559-14447-4-git-send-email-bruce.richardson@intel.com> <540D671B.9040104@6wind.com> In-Reply-To: <540D671B.9040104@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 08:44:45 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Monday, September 08, 2014 9:22 AM > To: Richardson, Bruce; dev@dpdk.org > Subject: Re: [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf >=20 > Hi Bruce, >=20 > On 08/28/2014 05:42 PM, Bruce Richardson wrote: > > From: Olivier Matz > > > > The initial role of rte_ctrlmbuf is to carry generic messages (data > > pointer + data length) but it's not used by the DPDK or it applications= . > > Keeping it implies: > > - loosing 1 byte in the rte_mbuf structure > > - having some dead code rte_mbuf.[ch] > > > > This patch removes this feature. Thanks to it, it is now possible to > > simplify the rte_mbuf structure by merging the rte_pktmbuf structure > > in it. This is done in next commit. > > > > Signed-off-by: Olivier Matz > > > > * Updated patch to HEAD. > > * Modified patch to retain the old function names for ctrl mbufs as > > macros. This helps with app compatibility, and allows the concept > > of a control mbuf to be reintroduced via a single-bit flag in > > a future change. > > * Updated the packet framework ip_pipeline example application to > > work following this change. > > > > Changes in v2: > > * Fixed whitespace errors introduced by this patch flagged by checkpatc= h > > > > Signed-off-by: Bruce Richardson >=20 > To be honest, I'm not convinced that keeping the old function names > is really required, but I suppose you had good reasons to reintroduce > them. Just for information, is it for compatibility purpose or is there > a real wish to reintroduce a sort of control mbuf in the future ? >=20 > Acked-by: Olivier Matz Compatibility primarily. However, it's a useful enough concept, and can be = controlled by having a single-bit flag as done in my second patch set. /Bruce