From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A4EEFB3B2 for ; Tue, 9 Sep 2014 10:58:58 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 09 Sep 2014 01:57:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,491,1406617200"; d="scan'208";a="570432155" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2014 02:03:21 -0700 Received: from irsmsx108.ger.corp.intel.com (163.33.3.3) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 9 Sep 2014 10:03:20 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by IRSMSX108.ger.corp.intel.com ([169.254.11.157]) with mapi id 14.03.0195.001; Tue, 9 Sep 2014 10:03:20 +0100 From: "Richardson, Bruce" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/6] Mbuf structure Rework, part 1 Thread-Index: AQHPwg6jUI0mSgjhvEeNJ+j/NK/PCZv3LRkAgAFoKkA= Date: Tue, 9 Sep 2014 09:03:19 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343EFAC3@IRSMSX103.ger.corp.intel.com> References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> <540DA1EC.10603@6wind.com> In-Reply-To: <540DA1EC.10603@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/6] Mbuf structure Rework, part 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 08:58:59 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Monday, September 08, 2014 1:33 PM > To: Richardson, Bruce; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/6] Mbuf structure Rework, part 1 >=20 > Hi Bruce, >=20 > On 08/27/2014 05:50 PM, Bruce Richardson wrote: > > This patch set does some initial pre-work to prepare the mbuf data stru= cture > > (and ixgbe vector driver to a lesser extent) for more major changes whi= ch > > will follow on in a subsequent patch set. [See previous RFC patch set f= or > > more indications of the future coming changes]. > > > > The main changes here are the flattening out of the mbuf data structure= , with > > much of it based off work by Olivier. The ctrlmbuf and pktmbuf structur= es are > > now gone, as is the vlan_macip structure. However, in this set, the con= cept > > of having a separate ctrl mbuf type is kept around. The plan is in a la= ter set > > when we expand the flags field to 64-bits, we can use a single bit in t= he flags > > to indicate a control packet. For now, though, the ctrlmbuf functions a= nd > macros > > just are aliases for the pktmbuf equivalents as much as possible. >=20 > I'm wondering it "struct rte_kni_mbuf" should be updated > accordingly each time "struct mbuf" is modified. >=20 > Regards, > Olivier Yes, it should. There are no changes needed for the part 1 patch set (6 pat= ches), as it does not change the actual field layout, it just flattens the = C definitions. I've already started working on an update to the second patc= h set (13 patches) including kni changes as part of it. /Bruce