Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level

["Richardson, Bruce" <bruce.richardson@intel.com>]

> -----Original Message-----
> From: Matthew Hall [mailto:mhall@mhcomputing.net]
> Sent: Monday, September 15, 2014 9:17 AM
> To: Richardson, Bruce; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level
> 
> Thanks for the ack Bruce! Used this one to clean up a lot of grubby app-side
> code and I hate forking open source for too long if it can be avoided.

No problem. With such huge patches as this the code review takes many hours of strenuous effort! :-)

/Bruce
> 
> Matthew.
> --
> Sent from my mobile device.
> 
> On September 15, 2014 1:14:57 AM PDT, "Richardson, Bruce"
> <bruce.richardson@intel.com> wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall
> >> Sent: Sunday, September 14, 2014 9:35 AM
> >> To: dev@dpdk.org
> >> Subject: [dpdk-dev] [PATCH] librte_log: add function to retrieve
> >log_level
> >>
> >> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> >> ---
> >>  lib/librte_eal/common/eal_common_log.c  | 7 +++++++
> >>  lib/librte_eal/common/include/rte_log.h | 6 ++++++
> >>  2 files changed, 13 insertions(+)
> >>
> >> diff --git a/lib/librte_eal/common/eal_common_log.c
> >> b/lib/librte_eal/common/eal_common_log.c
> >> index e4df0b9..d979f28 100644
> >> --- a/lib/librte_eal/common/eal_common_log.c
> >> +++ b/lib/librte_eal/common/eal_common_log.c
> >> @@ -176,6 +176,13 @@ rte_set_log_level(uint32_t level)
> >>  	rte_logs.level = (uint32_t)level;
> >>  }
> >>
> >> +/* Get global log level */
> >> +uint32_t
> >> +rte_get_log_level()
> >> +{
> >> +	return rte_logs.level;
> >> +}
> >> +
> >>  /* Set global log type */
> >>  void
> >>  rte_set_log_type(uint32_t type, int enable)
> >> diff --git a/lib/librte_eal/common/include/rte_log.h
> >> b/lib/librte_eal/common/include/rte_log.h
> >> index 565415a..7f1c2f9 100644
> >> --- a/lib/librte_eal/common/include/rte_log.h
> >> +++ b/lib/librte_eal/common/include/rte_log.h
> >> @@ -130,6 +130,12 @@ int rte_openlog_stream(FILE *f);
> >>  void rte_set_log_level(uint32_t level);
> >>
> >>  /**
> >> + * Get the global log level.
> >> + *
> >> + */
> >> +uint32_t rte_get_log_level(void);
> >> +
> >> +/**
> >>   * Enable or disable the log type.
> >>   *
> >>   * @param type
> >> --
> >> 1.9.1