DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Matthew Hall <mhall@mhcomputing.net>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level
Date: Mon, 15 Sep 2014 08:20:32 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>

> -----Original Message-----
> From: Matthew Hall [mailto:mhall@mhcomputing.net]
> Sent: Monday, September 15, 2014 9:17 AM
> To: Richardson, Bruce; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level
> 
> Thanks for the ack Bruce! Used this one to clean up a lot of grubby app-side
> code and I hate forking open source for too long if it can be avoided.

No problem. With such huge patches as this the code review takes many hours of strenuous effort! :-)

/Bruce
> 
> Matthew.
> --
> Sent from my mobile device.
> 
> On September 15, 2014 1:14:57 AM PDT, "Richardson, Bruce"
> <bruce.richardson@intel.com> wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall
> >> Sent: Sunday, September 14, 2014 9:35 AM
> >> To: dev@dpdk.org
> >> Subject: [dpdk-dev] [PATCH] librte_log: add function to retrieve
> >log_level
> >>
> >> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> >> ---
> >>  lib/librte_eal/common/eal_common_log.c  | 7 +++++++
> >>  lib/librte_eal/common/include/rte_log.h | 6 ++++++
> >>  2 files changed, 13 insertions(+)
> >>
> >> diff --git a/lib/librte_eal/common/eal_common_log.c
> >> b/lib/librte_eal/common/eal_common_log.c
> >> index e4df0b9..d979f28 100644
> >> --- a/lib/librte_eal/common/eal_common_log.c
> >> +++ b/lib/librte_eal/common/eal_common_log.c
> >> @@ -176,6 +176,13 @@ rte_set_log_level(uint32_t level)
> >>  	rte_logs.level = (uint32_t)level;
> >>  }
> >>
> >> +/* Get global log level */
> >> +uint32_t
> >> +rte_get_log_level()
> >> +{
> >> +	return rte_logs.level;
> >> +}
> >> +
> >>  /* Set global log type */
> >>  void
> >>  rte_set_log_type(uint32_t type, int enable)
> >> diff --git a/lib/librte_eal/common/include/rte_log.h
> >> b/lib/librte_eal/common/include/rte_log.h
> >> index 565415a..7f1c2f9 100644
> >> --- a/lib/librte_eal/common/include/rte_log.h
> >> +++ b/lib/librte_eal/common/include/rte_log.h
> >> @@ -130,6 +130,12 @@ int rte_openlog_stream(FILE *f);
> >>  void rte_set_log_level(uint32_t level);
> >>
> >>  /**
> >> + * Get the global log level.
> >> + *
> >> + */
> >> +uint32_t rte_get_log_level(void);
> >> +
> >> +/**
> >>   * Enable or disable the log type.
> >>   *
> >>   * @param type
> >> --
> >> 1.9.1


  reply	other threads:[~2014-09-15  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  8:34 Matthew Hall
2014-09-14  8:36 ` Matthew Hall
2014-09-15  8:14 ` Richardson, Bruce
2014-09-15  8:16   ` Matthew Hall
2014-09-15  8:20     ` Richardson, Bruce [this message]
2014-09-15  8:24       ` Matthew Hall
2014-09-18 13:29   ` Thomas Monjalon
2014-09-18 20:25     ` Matthew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mhall@mhcomputing.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git