From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A1E34B3A7 for ; Thu, 18 Sep 2014 14:30:46 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 18 Sep 2014 05:36:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="388020558" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 18 Sep 2014 05:30:56 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 18 Sep 2014 13:35:22 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by IRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id 14.03.0195.001; Thu, 18 Sep 2014 13:35:22 +0100 From: "Richardson, Bruce" To: Neil Horman , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used RHEL 6) Thread-Index: AQHP0y8i6ESf/18xKkWRib04BdvGMpwGqtYAgAAVSYCAABLtoA== Date: Thu, 18 Sep 2014 12:35:21 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0343F3406@IRSMSX103.ger.corp.intel.com> References: <1411037752-8000-1-git-send-email-bruce.richardson@intel.com> <5076244.KSjCyF24zI@xps13> <20140918122527.GE20389@hmsreliant.think-freely.org> In-Reply-To: <20140918122527.GE20389@hmsreliant.think-freely.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used RHEL 6) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 12:30:47 -0000 > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Thursday, September 18, 2014 1:25 PM > To: Thomas Monjalon > Cc: Richardson, Bruce; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (use= d RHEL > 6) >=20 > On Thu, Sep 18, 2014 at 01:09:16PM +0200, Thomas Monjalon wrote: > > > The refcnt field is contained within an anonymous union within the mb= uf > > > data structure, and gcc 4.4 gives an error about an unknown field unl= ess > > > the initialiser for the field is contained within extra braces. > > > > > > Signed-off-by: Bruce Richardson > > > > Acked-by: Thomas Monjalon > > > > Thanks Bruce, it is now applied. >=20 > Hang on here, we use anonymous unions all the time in RHEL6, and make > assignments to them frequently, and the compiler doesn't complain (see th= e > dropcount variable in sk_buff for an example). Not saying that this is a= big > deal, but can you explain a little more about what you're seeing when thi= s error > occurs, before we just paper over it? >=20 Originally reported on RHEL6 as a build failure. When I use gcc4.4 on Fedor= a 20, I get the following without this change: CC ixgbe_rxtx_vec.o =3D=3D Build lib/librte_table /home/bruce/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c: In function 'ix= gbe_rxq_vec_setup': /home/bruce/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:726: error: unkn= own field 'refcnt' specified in initializer compilation terminated due to -Wfatal-errors. make[5]: *** [ixgbe_rxtx_vec.o] Error 1 make[4]: *** [librte_pmd_ixgbe] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [lib] Error 2 make[2]: *** [all] Error 2 make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2 make: *** [install] Error 2 Regards, /Bruce