From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 2C56A7E79
for <dev@dpdk.org>; Fri, 17 Oct 2014 11:10:27 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga101.fm.intel.com with ESMTP; 17 Oct 2014 02:18:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,737,1406617200"; d="scan'208";a="616001710"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2014 02:17:59 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.175]) by
IRSMSX104.ger.corp.intel.com ([169.254.5.248]) with mapi id 14.03.0195.001;
Fri, 17 Oct 2014 10:17:59 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Wu, Jingjing"
<jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] lib/librte_ether: new filter APIs definition
Thread-Index: AQHP6ZkXF767HfPcvUi1BSYqsDcHKZwz76+AgAATNtA=
Date: Fri, 17 Oct 2014 09:17:58 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B03441FC75@IRSMSX103.ger.corp.intel.com>
References: <1413502161-31403-1-git-send-email-jingjing.wu@intel.com>
<4027817.y7ZgbDzL4P@xps13>
In-Reply-To: <4027817.y7ZgbDzL4P@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: new filter APIs definition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Oct 2014 09:10:27 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, October 17, 2014 10:08 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: new filter APIs definit=
ion
>=20
> 2014-10-17 07:29, Jingjing Wu:
> > Define new APIs to support configure multi-kind filters using same APIs=
,
> > instead of creating each API set for each kind of filter.
> > - rte_eth_dev_filter_supported
> > - rte_eth_dev_filter_ctrl
> >
> > Filter types, operations, and structures are defined specifically
> > in new header file lib/librte_eth/rte_dev_ctrl.h.
> >
> > As to the implementation discussion, please refer to
> > http://dpdk.org/ml/archives/dev/2014-September/005179.html
> [...]
> > --- /dev/null
> > +++ b/lib/librte_ether/rte_eth_ctrl.h
>=20
> Why this name? I think we can reserve this file for filtering API.
> So rte_eth_rx_filter.h would be more appropriate.
>=20
> > +/**
> > + * All generic operations to filters
> > + */
>=20
> rewording: "Generic operations on filters"
> Could you elaborate on "generic"? What would mean "specific"?
>=20
> > +enum rte_filter_op {
> > + RTE_ETH_FILTER_OP_NONE =3D 0,
> > + /**< used to check whether the type filter is supported */
> > + RTE_ETH_FILTER_OP_ADD, /**< add filter entry */
> > + RTE_ETH_FILTER_OP_UPDATE, /**< update filter entry */
> > + RTE_ETH_FILTER_OP_DELETE, /**< delete filter entry */
> > + RTE_ETH_FILTER_OP_FLUSH, /**< flush all entries */
> > + RTE_ETH_FILTER_OP_GET, /**< get filter entry */
> > + RTE_ETH_FILTER_OP_SET, /**< configurations */
> > + RTE_ETH_FILTER_OP_GET_INFO,
>=20
> Could we remove "OP", except for OP_NONE and OP_MAX?
OP_NONE =3D=3D> NOP or NOOP perhaps?
/Bruce