From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6C7A57E7B for ; Wed, 22 Oct 2014 12:47:12 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2014 03:55:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,768,1406617200"; d="scan'208";a="609238271" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 22 Oct 2014 03:55:30 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 11:55:30 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.175]) by IRSMSX151.ger.corp.intel.com ([169.254.4.227]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 11:55:29 +0100 From: "Richardson, Bruce" To: "dev@dpdk.org" Thread-Topic: [PATCH] ixgbe: Fix clang compilation issue Thread-Index: AQHP7eaVDpSsmG6F+EejQnmLuylA0pw78YZw Date: Wed, 22 Oct 2014 10:55:29 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0344219B2@IRSMSX103.ger.corp.intel.com> References: <1413975266-24066-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1413975266-24066-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 10:47:13 -0000 Self-nak, resent old patch. > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, October 22, 2014 11:54 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH] ixgbe: Fix clang compilation issue >=20 > Issue reported by Keith Wiles. > Clang fails with an error about a variable being used uninitialized: >=20 > CC ixgbe_rxtx_vec.o > /home/keithw/projects/dpdk-code/org- > dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30: > error: variable 'dma_addr0' is uninitialized > when used here [-Werror,-Wuninitialized] > dma_addr0 =3D _mm_xor_si128(dma_addr0, dma_addr0)= ; > ^~~~~~~~~ >=20 > This error can be fixed by replacing the call to xor which > takes two parameters, by a call to setzero, which does not take any. >=20 > Signed-off-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > index 457f267..2236250 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) > RTE_IXGBE_RXQ_REARM_THRESH) < 0) { > if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=3D > rxq->nb_rx_desc) { > - dma_addr0 =3D _mm_xor_si128(dma_addr0, dma_addr0); > + dma_addr0 =3D _mm_setzero_si128(); > for (i =3D 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) { > rxep[i].mbuf =3D &rxq->fake_mbuf; > _mm_store_si128((__m128i *)&rxdp[i].read, > -- > 1.9.3