Issue reported by Keith Wiles. Clang fails with an error about a variable being used uninitialized: CC ixgbe_rxtx_vec.o /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30: error: variable 'dma_addr0' is uninitialized when used here [-Werror,-Wuninitialized] dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0); ^~~~~~~~~ This error can be fixed by replacing the call to xor which takes two parameters, by a call to setzero, which does not take any. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 457f267..2236250 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) RTE_IXGBE_RXQ_REARM_THRESH) < 0) { if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >= rxq->nb_rx_desc) { - dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0); + dma_addr0 = _mm_setzero_si128(); for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) { rxep[i].mbuf = &rxq->fake_mbuf; _mm_store_si128((__m128i *)&rxdp[i].read, -- 1.9.3
Acked-by: Keith Wiles <keith.wiles@windiver.com>
On Sep 30, 2014, at 4:40 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> Issue reported by Keith Wiles.
> Clang fails with an error about a variable being used uninitialized:
>
> CC ixgbe_rxtx_vec.o
> /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30:
> error: variable 'dma_addr0' is uninitialized
> when used here [-Werror,-Wuninitialized]
> dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> ^~~~~~~~~
>
> This error can be fixed by replacing the call to xor which
> takes two parameters, by a call to setzero, which does not take any.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index 457f267..2236250 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq)
> RTE_IXGBE_RXQ_REARM_THRESH) < 0) {
> if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=
> rxq->nb_rx_desc) {
> - dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> + dma_addr0 = _mm_setzero_si128();
> for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) {
> rxep[i].mbuf = &rxq->fake_mbuf;
> _mm_store_si128((__m128i *)&rxdp[i].read,
> --
> 1.9.3
>
Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
> > Issue reported by Keith Wiles.
> > Clang fails with an error about a variable being used uninitialized:
> >
> > CC ixgbe_rxtx_vec.o
> > /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30:
> > error: variable 'dma_addr0' is uninitialized
> > when used here [-Werror,-Wuninitialized]
> > dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> > ^~~~~~~~~
> >
> > This error can be fixed by replacing the call to xor which
> > takes two parameters, by a call to setzero, which does not take any.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Keith Wiles <keith.wiles@windiver.com>
Acked and applied
Thanks
--
Thomas
Issue reported by Keith Wiles. Clang fails with an error about a variable being used uninitialized: CC ixgbe_rxtx_vec.o /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30: error: variable 'dma_addr0' is uninitialized when used here [-Werror,-Wuninitialized] dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0); ^~~~~~~~~ This error can be fixed by replacing the call to xor which takes two parameters, by a call to setzero, which does not take any. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 457f267..2236250 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) RTE_IXGBE_RXQ_REARM_THRESH) < 0) { if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >= rxq->nb_rx_desc) { - dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0); + dma_addr0 = _mm_setzero_si128(); for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) { rxep[i].mbuf = &rxq->fake_mbuf; _mm_store_si128((__m128i *)&rxdp[i].read, -- 1.9.3
Self-nak, resent old patch.
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Wednesday, October 22, 2014 11:54 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce
> Subject: [PATCH] ixgbe: Fix clang compilation issue
>
> Issue reported by Keith Wiles.
> Clang fails with an error about a variable being used uninitialized:
>
> CC ixgbe_rxtx_vec.o
> /home/keithw/projects/dpdk-code/org-
> dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30:
> error: variable 'dma_addr0' is uninitialized
> when used here [-Werror,-Wuninitialized]
> dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> ^~~~~~~~~
>
> This error can be fixed by replacing the call to xor which
> takes two parameters, by a call to setzero, which does not take any.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index 457f267..2236250 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq)
> RTE_IXGBE_RXQ_REARM_THRESH) < 0) {
> if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=
> rxq->nb_rx_desc) {
> - dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> + dma_addr0 = _mm_setzero_si128();
> for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) {
> rxep[i].mbuf = &rxq->fake_mbuf;
> _mm_store_si128((__m128i *)&rxdp[i].read,
> --
> 1.9.3