From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id A378EC89E
 for <dev@dpdk.org>; Fri, 19 Jun 2015 17:59:37 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 19 Jun 2015 08:59:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,644,1427785200"; d="scan'208";a="749701169"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by orsmga002.jf.intel.com with ESMTP; 19 Jun 2015 08:59:36 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.201]) with mapi id 14.03.0224.002;
 Fri, 19 Jun 2015 16:59:35 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Vladimir Medvedkin <medvedkinv@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS
Thread-Index: AQHQqqBxbL6d59sTtUiR5rHi8fB9Hp2z+1qA
Date: Fri, 19 Jun 2015 15:59:35 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B03455A83A@IRSMSX103.ger.corp.intel.com>
References: <1431097092-19790-1-git-send-email-medvedkinv@gmail.com>
 <1434725752-22847-1-git-send-email-medvedkinv@gmail.com>
In-Reply-To: <1434725752-22847-1-git-send-email-medvedkinv@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jun 2015 15:59:38 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vladimir Medvedkin
> Sent: Friday, June 19, 2015 3:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS
>=20
> v4 changes
> - Fix copyright
> - rename bswap_mask constant, add rte_ prefix
> - change rte_ipv[46]_tuple struct
> - change rte_thash_load_v6_addr prototype
>=20
> v3 changes
> - Rework API to be more generic
> - Add sctp_tag into tuple
>=20
> v2 changes
> - Add ipv6 support
> - Various style fixes
>=20

Missing signoff line.

> ---
>  lib/librte_hash/Makefile    |   1 +
>  lib/librte_hash/rte_thash.h | 202
> ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 203 insertions(+)
>  create mode 100644 lib/librte_hash/rte_thash.h
>=20
<...snip...>
> +
> +/* Byte swap mask used for converting IPv6 address 4-byte chunks to CPU
> byte order */
> +static const __m128i rte_thash_ipv6_bswap_mask =3D {0x0405060700010203,
> 0x0C0D0E0F08090A0B};
> +
> +#define RTE_THASH_V4_L3	 2	/*calculate hash of ipv4 header only*/
> +#define RTE_THASH_V4_L4	 3	/*calculate hash of ipv4 + transport
> headers*/
> +#define RTE_THASH_V6_L3	 8	/*calculate hash of ipv6 header only
> */
> +#define RTE_THASH_V6_L4	 9	/*calculate hash of ipv6 + transport
> headers */

I'm still not seeing why these values need to be defined here, rather than =
in a specific app.
Also, the choice of values for these defines seems strange to me? How were =
they chosen?

/Bruce