From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D3F4969C8 for ; Tue, 13 Oct 2015 18:05:41 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 13 Oct 2015 09:04:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,678,1437462000"; d="scan'208";a="825961161" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga002.fm.intel.com with ESMTP; 13 Oct 2015 09:04:11 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by IRSMSX151.ger.corp.intel.com ([169.254.4.183]) with mapi id 14.03.0248.002; Tue, 13 Oct 2015 17:04:10 +0100 From: "Richardson, Bruce" To: Stephen Hemminger , "De Lara Guarch, Pablo" Thread-Topic: [PATCH] crc: deinline crc functions Thread-Index: AQHQ/KIon6RStM9Z1UGPw9AoswgBxp5pp82A Date: Tue, 13 Oct 2015 16:04:10 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B03595A7B9@IRSMSX103.ger.corp.intel.com> References: <1443742658-24721-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1443742658-24721-1-git-send-email-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] crc: deinline crc functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 16:05:42 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, October 2, 2015 12:38 AM > To: Richardson, Bruce; De Lara Guarch, Pablo > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] crc: deinline crc functions >=20 > Because the CRC functions are inline and defined purely in the header > file, every component that uses these functions gets its own copy > of the software CRC table which is a big space waster. >=20 > Just deinline which give better long term ABI stablity anyway. >=20 > Signed-off-by: Stephen Hemminger While I think it's a good idea to de-inline the functions that do the calculations using the lookup tables, I think the functions that consist of a single assembly instruction should be kept as inline.=20 /Bruce