From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 7FB4A8E9F
 for <dev@dpdk.org>; Tue, 24 Nov 2015 17:30:06 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 24 Nov 2015 08:30:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,338,1444719600"; d="scan'208";a="846184373"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga001.fm.intel.com with ESMTP; 24 Nov 2015 08:30:02 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.163]) with mapi id 14.03.0248.002;
 Tue, 24 Nov 2015 16:30:01 +0000
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
 pmd_ring_autotest
Thread-Index: AQHRJtMrxtR41pTxRUavtzu9hUY4cZ6rXMwAgAAAKAA=
Date: Tue, 24 Nov 2015 16:30:00 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0359881D8@IRSMSX103.ger.corp.intel.com>
References: <PATCH>
 <1448292046-22682-1-git-send-email-bernard.iremonger@intel.com>
 <20151124161417.GA21112@bricha3-MOBL3>
 <8CEF83825BEC744B83065625E567D7C219F8A77B@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8A77B@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
 pmd_ring_autotest
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 16:30:07 -0000



> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Tuesday, November 24, 2015 4:29 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
> pmd_ring_autotest
>=20
> Hi Bruce,
>=20
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Tuesday, November 24, 2015 4:14 PM
> > To: Iremonger, Bernard <bernard.iremonger@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs
> > in pmd_ring_autotest
> >
> > On Mon, Nov 23, 2015 at 03:20:46PM +0000, Bernard Iremonger wrote:
> > > Use command line option --vdev=3Deth_ring0 to create port 0.
> > > Create two rings and five ethdevs in test_pmd_ring for ports 1 to 5.
> > > Improve test output by adding the port number to printf statements,
> > > and adding a printf describing each test.
> > >
> > > revise ring-based PMD doc to match latest ring PMD code.
> > >
> > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> >
> > The doc changes are not relevant to the unit test fixes, so should be
> > in a separate patch. The test changes themselves are good though, and
> > actually makes the test runable without having to find a very specific
> > command-line incantation to make things work right.
> >
> > Subject to this being split into two:
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>=20
> Will I keep your ack on both patches when I split them?
>=20
> Regards,
>=20
> Bernard.
>=20
Sure, feel free to.

/Bruce