From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7A50858DB for <dev@dpdk.org>; Mon, 30 Nov 2015 12:08:42 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 30 Nov 2015 03:08:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,364,1444719600"; d="scan'208";a="850385277" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2015 03:08:05 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX107.ger.corp.intel.com ([169.254.10.132]) with mapi id 14.03.0248.002; Mon, 30 Nov 2015 11:08:04 +0000 From: "Richardson, Bruce" <bruce.richardson@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com>, Panu Matilainen <pmatilai@redhat.com> Thread-Topic: [dpdk-dev] [PATCH] reserve 'make install' for future use Thread-Index: AQHRGH1R5l7mNw/cT02gAmPgqZ6ZoJ6O9HcAgAACAwCAHIoYAIABCqqAgAO3OYCABEiSEA== Date: Mon, 30 Nov 2015 11:08:03 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B03598A952@IRSMSX103.ger.corp.intel.com> References: <1446805454-17776-1-git-send-email-bruce.richardson@intel.com> <20151124165426.GA18656@bricha3-MOBL3> <565575F3.2000304@redhat.com> <3475702.r5OlE1Gpee@xps13> In-Reply-To: <3475702.r5OlE1Gpee@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] reserve 'make install' for future use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 30 Nov 2015 11:08:43 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, November 27, 2015 5:33 PM > To: Panu Matilainen <pmatilai@redhat.com>; Richardson, Bruce > <bruce.richardson@intel.com> > Cc: dev@dpdk.org; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] reserve 'make install' for future use >=20 > 2015-11-25 10:48, Panu Matilainen: > > On 11/24/2015 06:54 PM, Bruce Richardson wrote: > > > On Fri, Nov 06, 2015 at 02:04:54PM +0100, Thomas Monjalon wrote: > > >> 2015-11-06 12:57, Bruce Richardson: > > >>> So, any thoughts or comments on this? There has been lots of > > >>> discussion in this general area but nothing yet going into the > release to try and improve the situation. > > >>> > > >>> Are we just going to kick the problem down the road to the 2.3 > release? > > >> > > >> I plan to check these patches in the coming days for an integration > in 2.2. > > >> > > > Anything further on this? > > > Any thoughts from anyone else about this whole area of a saner > > > build/install system for DPDK and the various patches floating around= . > > > > Well, it seems we wont have a sane "make install" in 2.2 yet, but this > > is at least a step in the right direction so +1 from me. >=20 > Why is it a step in the right direction? >=20 > We just need to install the files in a different hierarchy and adapt the > makefiles to be able to compile an application while keeping the RTE_SDK > variable to specify the root directory (previously built thanks to > DESTDIR). > As the hierarchy could be tuned, we need more variables, e.g.: > DPDK_INC_DIR (default =3D RTE_SDK/include/dpdk) > DPDK_LIB_DIR (default =3D RTE_SDK/lib) >=20 > While doing it, we can have a specific handling of T=3D to keep > compatibility with the current (old) syntax. >=20 > What have I missed? >=20 I'm not sure our existing "make install" is suitable for use for this, with= out having it heavily overloaded. The existing T=3D behavior has support fo= r wildcards and compiling multiple instances at the same time - something t= hat won't work with a scheme to actually install DPDK throughout the filesy= stem hierarchy. Having it sometimes behave as now, and sometimes behave as = a standard make install is a bad idea IMHO, as it confuses things. Having l= ots of extra environment variables is also not a great idea, to my mind. My opinion is that we should rename our existing "make install" to somethin= g more suitable - my patch suggestion was "make sdk" but it could be "make = target" or something else if people prefer. Once that is done, we can then = look to implement a proper "make install" command that works in a standard = way, perhaps alongside a configure script of some description.=20 For an easy enough solution, I would look to apply this patch to create "ma= ke sdk" and also http://dpdk.org/dev/patchwork/patch/8076/ to have a "make = install" command that works in the build dir. That way: * you can have existing behavior using "make sdk T=3D<target>" * you can have standard(ish) configure/make/make install behavior using: make config T=3D<target> cd build make make install and the "make config" step can subsequently be wrapped in a configure scr= ipt to eliminate the need to know what the best target to use is, etc. /Bruce