From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 371915A65 for ; Wed, 11 May 2016 14:21:19 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 11 May 2016 05:21:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,608,1455004800"; d="scan'208";a="963586792" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 11 May 2016 05:21:18 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.54]) by irsmsx105.ger.corp.intel.com ([169.254.7.130]) with mapi id 14.03.0248.002; Wed, 11 May 2016 13:21:17 +0100 From: "Richardson, Bruce" To: "Yang, Ziye" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] librte_eal: fix wrong args operation in eal_parse_args Thread-Index: AQHRq3e7wquwQ+MVgUuwXaQe0D97M5+zjzQAgAAYluA= Date: Wed, 11 May 2016 12:21:16 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B035A51A28@IRSMSX103.ger.corp.intel.com> References: <1462944501-15852-1-git-send-email-ziye.yang@intel.com> <20160511112451.GA18868@bricha3-MOBL3> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODI5NDU2YmMtNDk3MS00ZDVlLTgzOGUtNGM4MzQ4NThlZGM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik15Yk9SbWFKRlJuU3lNQjAyODN5MGxFaEJzMWI2MEhFWHRuaGplXC9FYmZjPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] librte_eal: fix wrong args operation in eal_parse_args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 12:21:20 -0000 > -----Original Message----- > From: Yang, Ziye > Sent: Wednesday, May 11, 2016 12:51 PM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] librte_eal: fix wrong args operation in > eal_parse_args >=20 > Hi Bruce, >=20 > Could it be fixed later? If not, it should be documented. I faced this > issued today, and found that dpdk changed my last arg. In my mind, dpdk > should not change the argv[last], which will confuse the users. >=20 We can certainly consider changing it, but I am concerned about stability o= f existing apps. I think it needs some discussion and consensus on-list bef= ore a change like this is made. For right now, definitely the behavior should be documented. Would you cons= ider submitting a documentation update patch for this issue instead of this= code change? Thanks, /Bruce > Best Regards, > Ziye Yang >=20 > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, May 11, 2016 7:25 PM > To: Yang, Ziye > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_eal: fix wrong args operation in > eal_parse_args >=20 > On Wed, May 11, 2016 at 01:28:21PM +0800, Ziye Yang wrote: > > This patch is used to fix wrong operation on user input args. > > eal_parse_args function should not operate the args passed by the > > user. If the element in argv is generated by malloc function, changing > > it will cause memory issues when free the args. > > > > Signed-off-by: Ziye Yang > > --- > > lib/librte_eal/bsdapp/eal/eal.c | 2 -- > > lib/librte_eal/linuxapp/eal/eal.c | 2 -- > > 2 files changed, 4 deletions(-) > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c > > b/lib/librte_eal/bsdapp/eal/eal.c index 06bfd4e..0eef92d 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal.c > > +++ b/lib/librte_eal/bsdapp/eal/eal.c > > @@ -420,8 +420,6 @@ eal_parse_args(int argc, char **argv) > > goto out; > > } > > > > - if (optind >=3D 0) > > - argv[optind-1] =3D prgname; > > ret =3D optind-1; > > > > out: > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c > > b/lib/librte_eal/linuxapp/eal/eal.c > > index 8aafd51..ba9d1ac 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal.c > > +++ b/lib/librte_eal/linuxapp/eal/eal.c > > @@ -658,8 +658,6 @@ eal_parse_args(int argc, char **argv) > > goto out; > > } > > > > - if (optind >=3D 0) > > - argv[optind-1] =3D prgname; > > ret =3D optind-1; > > > > out: > This is a behaviour change in DPDK. The behaviour has always been that > after calling eal init, you can update your argv/argc values by the numbe= r > of args parsed and then parse your app args as normal, since argv[0] will > still point to your program name. While I agree that having the current > behaviour may cause some problems, changing this behaviour may break > applications that have been written to use the existing behaviour. >=20 > Since it is only the last EAL parameter arg that is modified, I think it > would be acceptable to have the behaviour well documented and then expect > any app to store a second copy of the pointer to be modified if it is > needed for a subsequent free call, for example. >=20 > /Bruce