From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E72895582 for ; Fri, 25 Nov 2016 10:55:43 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 25 Nov 2016 01:55:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="790605644" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 25 Nov 2016 01:55:41 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002; Fri, 25 Nov 2016 09:55:41 +0000 From: "Richardson, Bruce" To: Jerin Jacob , Thomas Monjalon CC: "dev@dpdk.org" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "Eads, Gage" Thread-Topic: [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs Thread-Index: AQHSRb5coyYkB2nOYEq5o60r3B32ZKDpGkiAgABeByA= Date: Fri, 25 Nov 2016 09:55:39 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B035B4EB9F@IRSMSX103.ger.corp.intel.com> References: <1479447902-3700-1-git-send-email-jerin.jacob@caviumnetworks.com> <1479447902-3700-3-git-send-email-jerin.jacob@caviumnetworks.com> <4871697.UraAQdum7A@xps13> <20161125041750.GA18469@localhost.localdomain> In-Reply-To: <20161125041750.GA18469@localhost.localdomain> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQyNWYxN2MtMDFiNS00NmQ4LWJlNGYtOTdkNTIzNDJmYmE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRSOXl5WHZ4TnRXU0l0bGFCc2tTNk5tcmJjUmlSNWdxYkxCbHZzUlhvYkE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 09:55:44 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Friday, November 25, 2016 4:18 AM > To: Thomas Monjalon > Cc: dev@dpdk.org; Richardson, Bruce ; Van > Haaren, Harry ; hemant.agrawal@nxp.com; Eads, > Gage > Subject: Re: [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound > APIs >=20 > On Wed, Nov 23, 2016 at 08:18:09PM +0100, Thomas Monjalon wrote: > > 2016-11-18 11:15, Jerin Jacob: > > > This patch set defines the southbound driver interface and > > > implements the common code required for northbound eventdev API > > > interface. > > > > Please make two separate patches. >=20 > OK >=20 > > > > > +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG > > > +#define RTE_PMD_DEBUG_TRACE(...) \ > > > + rte_pmd_debug_trace(__func__, __VA_ARGS__) #else #define > > > +RTE_PMD_DEBUG_TRACE(...) #endif > > > > I would like to discuss the need for a debug option as there is > > already a log level. >=20 > IMO, we don't need this. However, RTE_FUNC_PTR_OR_ERR_RET needs the > definition of RTE_PMD_DEBUG_TRACE inorder to compile. I think we can > remove it when it get fixed in EAL layer. >=20 > > > > > +/* Logging Macros */ > > > +#define EDEV_LOG_ERR(fmt, args...) \ > > > > Every symbols and macros in an exported header must be prefixed by RTE_= . > > > OK. I will fix it >=20 > > > +/* Macros to check for valid device */ #define > > > +RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \ > > > > Sometimes you use RTE_EVENT_DEV_ and sometimes RTE_EVENTDEV. > > (I prefer the latter). >=20 > I choose the naming conversion based on the interface. API side it is > rte_event_ and driver side it is rte_eventdev_* >=20 > rte_event_dev_count; > rte_event_dev_get_dev_id > rte_event_dev_socket_id; > rte_event_dev_info_get; > rte_event_dev_configure; > rte_event_dev_start; > rte_event_dev_stop; > rte_event_dev_close; > rte_event_dev_dump; >=20 > rte_event_port_default_conf_get; > rte_event_port_setup; > rte_event_port_dequeue_depth; > rte_event_port_enqueue_depth; > rte_event_port_count; > rte_event_port_link; > rte_event_port_unlink; > rte_event_port_links_get; >=20 > rte_event_queue_default_conf_get > rte_event_queue_setup; > rte_event_queue_count; > rte_event_queue_priority; >=20 > rte_event_dequeue_wait_time; >=20 > rte_eventdev_pmd_allocate; > rte_eventdev_pmd_release; > rte_eventdev_pmd_vdev_init; > rte_eventdev_pmd_pci_probe; > rte_eventdev_pmd_pci_remove; For this last set, you probably are ok prefixing with just "rte_event_pmd_"= , and drop the "dev" as unnecessary. That makes everything have a prefix of= "rte_event_" and thereafter dev, port, queue, or pmd as appropriate. /Bruce