From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2E3A92C58 for ; Wed, 21 Jun 2017 14:52:41 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2017 05:52:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,369,1493708400"; d="scan'208";a="101999115" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga002.jf.intel.com with ESMTP; 21 Jun 2017 05:52:39 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.26]) by IRSMSX154.ger.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0319.002; Wed, 21 Jun 2017 13:52:38 +0100 From: "Richardson, Bruce" To: Thomas Monjalon CC: "gaetan.rivet@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH] mk: symlink every headers first Thread-Index: AQHS6gtGeF+AdBuxuEW4MchH7MdQ86IvHcEA///zVQCAADUEsA== Date: Wed, 21 Jun 2017 12:52:38 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B07218097B@IRSMSX104.ger.corp.intel.com> References: <20170620212139.9508-1-thomas@monjalon.net> <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> <1569330.jjeHmIoRYc@xps> In-Reply-To: <1569330.jjeHmIoRYc@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTVmM2Y4YjktYWIzOS00NWMxLWI1ZGEtMTQ1MzgzY2YzYmZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InVRR3NOWVlxdHdBd2ZQdWIrRFZ2ZWZoUjgyR0V4eVNJUlh5YnYzSG9ZNmc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 12:52:42 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, June 21, 2017 11:42 AM > To: Richardson, Bruce > Cc: gaetan.rivet@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first >=20 > 21/06/2017 12:27, Bruce Richardson: > > On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: > > > If a library or a build tool uses a definition from a driver, there > > > is a build ordering issue, like seen when moving PCI code into a bus > > > driver. > > > > > > One option is to keep PCI helpers and some common definitions in EAL. > > > The other option is to symlink every headers at the beginning of the > > > build so they can be included by any other component. > > > > > > This patch shows how to achieve the second option. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > My 2c. > > > > This may be worth doing, however, two points to consider. > > > > 1. If we look to change build system this may not be worth doing > > unless a compelling need becomes obvious in the short term. In the > > meantime, for cases where it is needed... > > 2. libraries can already access the includes from drivers or other > > places fairly easily, just by adding the relevant "-I" flag to the > > CFLAGS for that lib. >=20 > You mean adding a -I pointing to source location instead of the build > directory? >=20 Yep. Easy workaround for limited cases where it is needed. It's been done b= efore in our code, not sure there are any instances left after the rework o= f the last couple of releases, but we certainly used to have that scheme in= the past and it didn't cause us a single problem as I recall. /Bruce